Skip to content

Add aria-label to the free search field in the search filters#7742

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/a11y-filters-search-field-label
Mar 26, 2021
Merged

Add aria-label to the free search field in the search filters#7742
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/a11y-filters-search-field-label

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

The free search field in the filters section has a title attribute but the field is missing a <label> element.

For accessibility, add the aria-label attribute for the search fields to fix the missing <label> element.

📌 Related Issues

Testing

Run one of the search pages through an automated accessibility check.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added the type: fix PRs that implement a fix for a bug label Mar 26, 2021
@mrcasals mrcasals merged commit ed62e87 into decidim:develop Mar 26, 2021
@ahukkanen ahukkanen deleted the fix/a11y-filters-search-field-label branch March 26, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants