Skip to content

Add aria-atomic="true" to the alert role elements#7666

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-alert-error-identifications
Mar 23, 2021
Merged

Add aria-atomic="true" to the alert role elements#7666
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-alert-error-identifications

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 22, 2021

🎩 What? Why?

In order to make all assistive technologies read the assertive alerts on the page, we need to apply the aria-atomic=true attributes on the alert elements.

📌 Related Issues

Testing

Test the alerts with all assistive technologies.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals merged commit 7af029d into decidim:develop Mar 23, 2021
@ahukkanen ahukkanen deleted the fix/a11y-alert-error-identifications branch March 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants