Skip to content

Add proper ARIA roles for header and footer#7658

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-header-footer-roles
Mar 22, 2021
Merged

Add proper ARIA roles for header and footer#7658
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-header-footer-roles

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 21, 2021

🎩 What? Why?

The header and footer are lacking the correct ARIA roles which tell screen readers these are repeatable parts of the page.

This also adds the .header and .footer classes for these elements respectively, for easier targeting of elements inside these wrappers.

WCAG 2.1 A / SC 1.3.1

📌 Related Issues

Testing

Check the source of any page.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants