Add proper ARIA roles for header and footer#7658
Merged
mrcasals merged 1 commit intodecidim:developfrom Mar 22, 2021
Merged
Conversation
mrcasals
approved these changes
Mar 22, 2021
This was referenced Mar 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The header and footer are lacking the correct ARIA roles which tell screen readers these are repeatable parts of the page.
bannerrole for the headercontentinforole for the footerThis also adds the
.headerand.footerclasses for these elements respectively, for easier targeting of elements inside these wrappers.WCAG 2.1 A / SC 1.3.1
📌 Related Issues
Testing
Check the source of any page.
📋 Checklist
docs/.