Skip to content

Fix comments opinion toggle accessibility#7657

Merged
mrcasals merged 4 commits intodecidim:developfrom
mainio:fix/a11y-comment-opinion-toggle-labels
Mar 22, 2021
Merged

Fix comments opinion toggle accessibility#7657
mrcasals merged 4 commits intodecidim:developfrom
mainio:fix/a11y-comment-opinion-toggle-labels

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 21, 2021

🎩 What? Why?

  • The comments opinion toggles do not have accessibility labels - fix that
  • The comments opinion toggles do not have accessibility states - fix that
  • The comments opinion toggles will not announce the changed state - fix that

WCAG 2.1 A / SC 4.1.2

📌 Related Issues

Testing

Enable screen reader and try the comments opinion toggles (switch focus between the buttons and try changing their states).

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

- Add proper labels for the opinion toggle buttons
- Add proper states for the opinion toggle buttons
- Announce the change after user changes the state
@mrcasals mrcasals added module: comments type: fix PRs that implement a fix for a bug labels Mar 22, 2021
@mrcasals mrcasals merged commit 340051c into decidim:develop Mar 22, 2021
@ahukkanen ahukkanen deleted the fix/a11y-comment-opinion-toggle-labels branch March 22, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants