Skip to content

Add reason fieldset to the report modal for accessibility#7665

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-report-reason-fieldset
Mar 23, 2021
Merged

Add reason fieldset to the report modal for accessibility#7665
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-report-reason-fieldset

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 22, 2021

🎩 What? Why?

Add a fieldset for the report modal's reason radios (issue reported by automated accessibility audit).

WCAG 2.1 A / SC 1.3.1, 3.3.2

📌 Related Issues

Testing

Audit pages with comments with multiple accessibility audit tools.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals merged commit d2f6415 into decidim:develop Mar 23, 2021
@ahukkanen ahukkanen deleted the fix/a11y-report-reason-fieldset branch March 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants