Skip to content

Accessibility fixes for comments#7741

Merged
mrcasals merged 3 commits intodecidim:developfrom
mainio:fix/a11y-fixes-for-comments
Mar 26, 2021
Merged

Accessibility fixes for comments#7741
mrcasals merged 3 commits intodecidim:developfrom
mainio:fix/a11y-fixes-for-comments

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This applies two accessibility fixes to the comments section:

  1. Logical headings order (tested on a single proposal page)
  2. The order dropdown fix for the axe-core accessibility audit tool (same fix as Fix dropdown menu accessibility audits #7708)

📌 Related Issues

Testing

Run the accessibility audit tool on a single proposal page with comments enabled.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added module: comments type: fix PRs that implement a fix for a bug labels Mar 26, 2021
@mrcasals mrcasals merged commit cbf9df2 into decidim:develop Mar 26, 2021
@ahukkanen ahukkanen deleted the fix/a11y-fixes-for-comments branch March 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants