Skip to content

Fix the missing aria-controls element on pages with comments#7664

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-comments-ordering-control
Mar 23, 2021
Merged

Fix the missing aria-controls element on pages with comments#7664
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/a11y-comments-ordering-control

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Mar 22, 2021

🎩 What? Why?

We have an element on the page with aria-controls pointer attribute here:

There is no element on the page with such ID.

This adds the ID.

📌 Related Issues

Testing

Test one of the pages with comments using an automated accessibility audit tool.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals added module: comments type: fix PRs that implement a fix for a bug labels Mar 22, 2021
@mrcasals mrcasals merged commit ac67237 into decidim:develop Mar 23, 2021
@ahukkanen ahukkanen deleted the fix/a11y-comments-ordering-control branch March 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants