Merged
Conversation
* [plg_content_pagenavigation]Code style * XML CS * options in one line * indent
* [plg_content_pagebreak]Code style * more XML CS * options on one line + indent
* [plg_content_loadmodule]XML code style * XML CS * options in one line
* [plg_captcha_recaptcha]code style * indent * indent * XML CS * options in one line
* Improve select contact modal * Add Edit contact modal + simplify and clean code * Language string consistency: COM_CONTACT_EDIT_CONTACT « Edit Contact » as for other components: com_content, com_categories…
…MPAT, 'UTF-8') (#10443) * Update index.php * Update login.php * Update manager.php * Update view.html.php * Update blog.php * Update default_items.php * Update default.php
…MPAT, 'UTF-8') (#10417) * Update mod_articles_archive.php * Update mod_articles_latest.php * Update mod_articles_news.php * Update mod_articles_popular.php * Update mod_languages.php * Update mod_languages.php * Update mod_stats.php * Update modules.php * Update helper.php
…F-8') (#10430) * Update head.php * Update modules.php * Update offline.php * Update default.php * Update vote.php
…8') (#10422) * Update mod_footer.php * Update mod_whosonline.php * Update mod_feed.php * Update mod_banners.php * Update mod_breadcrumbs.php * Update mod_feed.php * Update mod_random_image.php * Update mod_related_items.php * Update mod_tags_similar.php * Update mod_menu.php * Update error.php * Update users.php
…ces in the Link to the Feed #9033
…e for fieldset description (#10622) * Add info alert style to fieldset description * Fix hidden field (no html) + Code Style Review
* beez3 to html5 * use $this instead of $doc
* Fix JUri::root() assignment from backend app constuctor This may not seem any important but I'd say it still is breaking. Try running Joomla in a subdirectory `administrator` under your web root, and open backend. It would break. * dirname gives a slash for 1st level subdirectory Removed trailing slash, which eventually only occurs when queried for a root domain Joomla setup, i.e. not in a subdirectory installation.
grammatical fix: checke -> checked , line 137
…ew item + other issues (#10894) * try to solve remaining acl problems - initial commit * some corrections * code improvements * ups * more improvements * simplify * better comments * ups * Update application.php * Update rules.php * more problems solved * only chekc parent asset if not global config * call things by it's name * further simplify code * further improvements * revert something and make comment because of new * add some temporary tooltip debug information on calculated permissions * improve tooltip debugging information * even better debug * name, not title * minor improvements * minor debug improvements * add known issues as to do comments * remove debug information * use clear as $query is already instantiated. (thanks roland) * cs * cs 1: wrap long lines * cs 2: multiline comments * cs 3: one final multiline comment * minor code ordering and comments
* Remove API doc URLs for JTable * Change php.net links to use HTTPS mirror * Update GitHub URLs * Update other miscellaneous URLs * Too many spaces
* modify PEAR.Functions.ValidDefaultValue excepions * test removal of Generic.CodeAnalysis.UselessOverridingMethod for modules * remove Generic.CodeAnalysis.UselessOverridingMethod from ruleset
Automatically Fixed with the PHPCS 2 fixers End of line character is invalid; expected "\n" but found "\r\n" at line 1 No blank line found after control structure / Please consider an empty line before the return statement;
No blank line found after control structure
* Fix submenu top position * Fix missing pointer for dropdown-menu * Run generates * Revert "Run generates" This reverts commit 6cd63ab. * Run generates * Run generatecss with missing rtf * Fix pointer display for dropdown-menu * Revert * Fix submenu placement in RTL * Revert "Fix pointer display for dropdown-menu" This reverts commit 9676831. * Revert "Revert" This reverts commit 8c324ba. * Fix dropdown pointer in RTL
alex7r
pushed a commit
that referenced
this pull request
Nov 1, 2016
default needs to be enabled by default for B/C
alex7r
pushed a commit
that referenced
this pull request
Jan 28, 2017
- removal of some unused variables (and inserted todo's if unclear) - removal of null assignments on class properties;
alex7r
pushed a commit
that referenced
this pull request
Jan 28, 2017
Some improvements in tests #4:
alex7r
pushed a commit
that referenced
this pull request
Jun 19, 2017
… (joomla#12293) * Cleanups, fixes and a bit of optimizations for site/components batch #4 - com_mailto - com_newsfeeds - com_search Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Missed to convert `and` and `or` * Some more fixes after conflict resolution * - Changed some things according to reviewer's suggestions - Some more changes in updated stuff * Reversed a change according to reviewer's correct comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.