Fix JUri::root() assignment from backend app constuctor#8587
Fix JUri::root() assignment from backend app constuctor#8587roland-d merged 2 commits intojoomla:stagingfrom
Conversation
This may not seem any important but I'd say it still is breaking. Try running Joomla in a subdirectory `administrator` under your web root, and open backend. It would break.
|
I have tested this item ✅ successfully on fb59736 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
Removed trailing slash, which eventually only occurs when queried for a root domain Joomla setup, i.e. not in a subdirectory installation.
|
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
|
I have tested this item ✅ successfully on 9250008 I've installed Joomla in a folder called /administrator/ and going to the /administrator/administrator/ results in a blank page. I've manually added the code of this patch to the file, and it solves the problem. Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
|
I have tested this item ✅ successfully on 9250008 I've installed Joomla in a folder called /administrator/ and going to the /administrator/administrator/ results in a blank page. I've manually added the code of this patch to the file, and it solves the problem. // JUri::root(null, str_ireplace('/' . $this->getName(), '', JUri::base(true))); Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
|
I have tested this item ✅ successfully on 9250008 e.g. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
|
RTC based on testing This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8587. |
|
Thanks everybody |
This may not seem any important but I'd say it still is breaking. Try running Joomla in a subdirectory
administratorunder your web root, and open backend. It would break.dirnamewill work on all platforms asJUri::base(true)always uses/as the path separator. Also there is no trailing slash in the return value ofJUri::base(true)