Skip to content

[plg_captcha_recaptcha]code style#10471

Merged
rdeutz merged 5 commits intojoomla:stagingfrom
wojsmol:plg_captcha_recaptcha-cs
May 16, 2016
Merged

[plg_captcha_recaptcha]code style#10471
rdeutz merged 5 commits intojoomla:stagingfrom
wojsmol:plg_captcha_recaptcha-cs

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented May 15, 2016

Summary of Changes

Code style changes for plg_captcha_recaptcha

Testing Instructions

code review

showon="version:1.0"
filter=""
>
<option
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in the options are not needed. Is not a very big line and makes it harder to read IMO.

@cyrez
Copy link
Copy Markdown
Contributor

cyrez commented May 15, 2016

I have tested this item ✅ successfully on 9fbdb1f

On code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10471.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 9fbdb1f

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10471.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10471.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 16, 2016
@rdeutz rdeutz merged commit cbc4131 into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@wojsmol wojsmol deleted the plg_captcha_recaptcha-cs branch May 16, 2016 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants