Skip to content

Modal com_contact: improve Select & Edit Contact#10457

Merged
rdeutz merged 3 commits intojoomla:stagingfrom
cyrez:modal-com_contacts-improve-select-&-edit-contact
May 16, 2016
Merged

Modal com_contact: improve Select & Edit Contact#10457
rdeutz merged 3 commits intojoomla:stagingfrom
cyrez:modal-com_contacts-improve-select-&-edit-contact

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented May 14, 2016 •
edited by brianteeman
Loading

Improve modals to select and to edit a contact.
Note: to be testing on staging.

Summary of Changes

  • When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
  • Remove inline CSS
  • Content is embedded in a container div (using already existing container-popup class for modal.php)
  • Add empty lines to improve the readability
  • Add viewport dimensions (new 3.6.0-dev)
  • Contact edit modal is simplified (load edit layout, so no dupplicated code)
  • Fix Edit button when current associated contact in data is not the selected contact
  • Control if modal, in edit layout
  • Add Save (keep modal open), Save & Close and Close button to the footer of the modal
  • Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
  • Fix consistency of fieldsets $this->ignore_fieldsets, and add missing tabs, and remove dupplicated fieldset metadata (as using now correct edit view inside the modal)
  • Consistency of language string COM_CONTACT_EDIT_CONTACT with other components (com_content, com_categories...) : "Edit Contact" and not "Contact".

Testing Instructions (Staging + Multilanguages enabled!)

  • Go to Components > Contacts > open a contact, and go to Associations tab to select associated contact to open the modal.
  • Verify tooltip placement is bottom, and not truncated
  • Verify the modal size now is proportionnal to viewport (modal is 80/100th viewport width, and modal-body is 70/100th viewport height)
  • Select an associated contact and save the contact to show edit button
  • Open Edit modal and play with it ;-)
  • Do the same in a menu item type "Single contact", for Select and Edit contact.

Same rendering as for Categories in PR #10441 (screenshots)

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 14, 2016
@cyrez cyrez mentioned this pull request May 14, 2016
Merged
@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented May 14, 2016

I have tested this item ✅ successfully on 9f26ce1

Nice work yet again.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented May 14, 2016

just an additional info, this modals also exists in menu item -> single contact (you don't need multilanguage there to test).

@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented May 14, 2016 •
edited
Loading

just an additional info, this modals also exists in menu item -> single contact (you don't need multilanguage there to test).

Yes, you don't need multilanguage there, but it's good to test both places where those modals are used ;-) (as in menu, "clear" is not allowed by field attribute, but is allowed (as associated contact is optional) in associations).
So, only on multilanguage, you will be able to test the "clear" button.

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 15, 2016

I have tested this item ✅ successfully on 9f26ce1

Installed the latest staging and setup a multilangual website.
All works as described, great!

Will you do the same for the Contacts Categories?
I'll be happy to test that too!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented May 15, 2016

Will you do the same for the Contacts Categories?

That one is already done #10441

@MATsxm
Copy link
Copy Markdown

MATsxm commented May 15, 2016

I have tested this item ✅ successfully on 9f26ce1

Works great - Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 15, 2016

That one is already done #10441

Confirmed!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented May 15, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10457.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 15, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented May 16, 2016

@JoomliC, not for this PR, but did you notice there is another edit modal for creating/editing a module?

That i know of, only in Menus -> Manage (modules button in "Linked Modules")

@rdeutz rdeutz merged commit a313be8 into joomla:staging May 16, 2016
@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented May 16, 2016

That i know of, only in Menus -> Manage (modules button in "Linked Modules")

There are the same modals as for the assignment modules in menu edition.
And it is in 3.5 the only edit modal opening in a modal. In fact, i based all work done for 3.6.0 on this one ;-)
I'm currently working on newsfeeds modal, and the next one will be modules with only a few improvements, to have consistence with already edit modals done : category and contact.
Edit article was done, but will do too a new PR just to add the Save button there too, and to use same file structure as done here ;-)
So, still in process, but good to point me this location for where module edit is used too! 👍

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented May 16, 2016

Thanks @andrepereiradasilva @BurtNL @MATsxm for testing 👍
Just opened a PR for com_newsfeeds modal (with same testing instructions and expected results) ;-)
#10516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cyrez @andrepereiradasilva @BurtNL @MATsxm @brianteeman @rdeutz @joomla-cms-bot