Modal com_newsfeeds: improve Select & Edit Newsfeed#10516
Merged
roland-d merged 2 commits intojoomla:stagingfrom May 16, 2016
Merged
Modal com_newsfeeds: improve Select & Edit Newsfeed#10516roland-d merged 2 commits intojoomla:stagingfrom
roland-d merged 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 2e2f7e1 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516. |
|
I have tested this item ✅ successfully on 2e2f7e1 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516. |
Contributor
|
Thanks everybody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve modals to select and to edit a news feed.
Note: to be testing on staging.
Summary of Changes
3.6.0-dev)Save(keep modal open),Save & CloseandClosebutton to the footer of the modal$this->ignore_fieldsets, and add missing tabs, and remove dupplicated fieldset metadata (as using now correct edit view inside the modal)Testing Instructions (Staging + Multilanguages enabled!)
Associationstab to select associated news feed to open the modal.Same rendering as for Categories in PR #10441 (screenshots)