Skip to content

Modal com_newsfeeds: improve Select & Edit Newsfeed#10516

Merged
roland-d merged 2 commits intojoomla:stagingfrom
cyrez:Modal-com_newsfeeds-improve-Select-and-Edit-Newsfeed
May 16, 2016
Merged

Modal com_newsfeeds: improve Select & Edit Newsfeed#10516
roland-d merged 2 commits intojoomla:stagingfrom
cyrez:Modal-com_newsfeeds-improve-Select-and-Edit-Newsfeed

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented May 16, 2016

Improve modals to select and to edit a news feed.
Note: to be testing on staging.

Summary of Changes

  • When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
  • Remove inline CSS
  • Content is embedded in a container div (using already existing container-popup class for modal.php)
  • Add empty lines to improve the readability
  • Add viewport dimensions (new 3.6.0-dev)
  • News feed edit modal is simplified (load edit layout, so no dupplicated code)
  • Fix Edit button when current associated news feed in data is not the selected news feed
  • Control if modal, in edit layout
  • Add Save (keep modal open), Save & Close and Close button to the footer of the modal
  • Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
  • Fix consistency of fieldsets $this->ignore_fieldsets, and add missing tabs, and remove dupplicated fieldset metadata (as using now correct edit view inside the modal)

Testing Instructions (Staging + Multilanguages enabled!)

  • Go to Components > News Feeds > open a news feed, and go to Associations tab to select associated news feed to open the modal.
  • Verify tooltip placement is bottom, and not truncated
  • Verify the modal size now is proportionnal to viewport (modal is 80/100th viewport width, and modal-body is 70/100th viewport height)
  • Select an associated news feed and save the news feed to show edit button
  • Open Edit modal and play with it ;-)
  • Do the same in a menu item type "Single news feed", for Select and Edit news feed.

Same rendering as for Categories in PR #10441 (screenshots)

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 2e2f7e1

All worked fine.
Great work again!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

@BurtNL
Copy link
Copy Markdown

BurtNL commented May 16, 2016

I have tested this item ✅ successfully on 2e2f7e1

Tested successfully, works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10516.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 16, 2016
@roland-d roland-d merged commit 6ee4c6f into joomla:staging May 16, 2016
@roland-d
Copy link
Copy Markdown
Contributor

Thanks everybody

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants