Modal com_categories: improve Select & Edit Category by cyrez · Pull Request #10441 · joomla/joomla-cms

cyrez · 2016-05-12T14:57:22Z

Improve modals to select and to edit a category.
Note: to be testing on staging.

Summary of Changes

When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2). This PR sets the tooltip placement to bottom to fix this issue.
Remove inline CSS
Content is embedded in a container div (using already existing container-popup class for modal.php)
Add empty lines to improve the readability
Add viewport dimensions (new 3.6.0-dev)
Category edit modal is simplify (loading edit layout, so no dupplicated code)
Fix Edit button when current associated category in data is not the category selected
Control if modal, in edit layout
Add Save, Save & Close and Close button to the footer of the modal
Fix Edit modal not opening as a modal (missing bootstrap.renderModal for Edit modal)
Fix Uncaught SyntaxError: Unexpected token ) in select category modal

Testing Instructions (Staging + Multilanguages enabled!)

Go to Contents > Categories > open a categorie, and go to Associations tab to select associated category to open the modal.
Verify tooltip placement is bottom, and not truncated
Verify the modal size now is proportionnal to viewport (width 80/100th viewport width, and modal-body is 70/100th viewport height)
Select an associated category and save the category to show edit button
Open Edit modal and play with it ;-)

Select Category Before Patch

Select Category After Patch

Edit Category Before Patch
Open in a new window...

Edit Category After Patch
Open in a modal

andrepereiradasilva · 2016-05-12T15:26:25Z

in the modal, got a JS error Uncaught SyntaxError: Unexpected token ) on selecting a category.

BTW did you notice the lack of modal in the "Edit" button (the button appears after saving the category with the association)?

andrepereiradasilva · 2016-05-12T15:29:25Z

ups, the js error is already there without your PR ..., so tested with success

andrepereiradasilva · 2016-05-12T15:30:07Z

I have tested this item ✅ successfully on d738268

as said js error was already there so this PR does what is proposed to do.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

cyrez · 2016-05-12T16:07:26Z

@andrepereiradasilva yes error was there before, but prepare yourself for a new test, as i will fix it (this PR is a good occasion to fix issue!) ;-)

joomla-cms-bot · 2016-05-12T17:22:51Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

joomla-cms-bot · 2016-05-12T17:24:44Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

joomla-cms-bot · 2016-05-12T17:26:39Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

cyrez · 2016-05-12T17:29:14Z

@andrepereiradasilva JS error is now fixed here : 96e2bb0

But, i will put this PR in stand-by until tomorrow, as i will see to add directly in this PR, the modal to edit category and do a 2-in-1 PR for modals select and edit category ;-)

andrepereiradasilva · 2016-05-12T18:00:51Z

ok will wait then.

joomla-cms-bot · 2016-05-13T16:49:55Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

cyrez · 2016-05-13T17:05:06Z

@andrepereiradasilva That's ok!

Issue Fixed
And PR for both Select and Edit category modals ;-)

Ready for testing! (and to be then the base for other ones, if all is ok!) 👍

andrepereiradasilva · 2016-05-13T17:05:40Z

administrator/components/com_categories/models/fields/modal/category.php

 		}

+		$urlSelect = $linkCategories . '&amp;' . JSession::getFormToken() . '=1';
+		$urlEdit   = $linkCategory . '&amp;id=' . $value . '&amp;' . JSession::getFormToken() . '=1';


shouldn't all internal URL be passed trough JRoute::_()?

The urls there are the source url (remote) for the iframe inside the modal (set here : https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/modal/iframe.php#L46).
So, as inside the modal-body iframe of the modal, should not be needed, and not sure in fact that is should be used... (none of all bootstrap modals iframe use JRoute ;-) )

humm ... ok then i guess is not needed here

Indeed, this is a good question... and wonder who can answer ? :-|

andrepereiradasilva · 2016-05-13T17:18:16Z

I have tested this item ✅ successfully on 443897d

Tested with success.

Solves a lot of issues with the "Edit" modal, js errors and the "Clear" button.

Also now the "Edit" is a modal with "Close", "Save" and "Save & Close" buttons! 👍

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

andrepereiradasilva · 2016-05-13T17:31:27Z

@JoomliC really nice work!

The modals are getting much more user friendly.
Also you're solving a lot of bugs!

I hope all modals get reviewed for 3.6.0.

cyrez · 2016-05-13T17:43:25Z

Thank you @andrepereiradasilva !
Yes, if this one for category is ok, i will update article and module (with save button) and will do the ones for contact and newsfeed.
I think i can do this for 3.6.0 ;-)

BurtNL · 2016-05-13T19:58:54Z

I have tested this item ✅ successfully on 443897d

Everything works as described. Great!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

brianteeman · 2016-05-13T20:04:24Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10441.}

cyrez · 2016-05-14T11:31:34Z

@andrepereiradasilva @BurtNL Thanks for testing!
A new one just added for com_contacts #10457 ;-)

cyrez added 2 commits May 12, 2016 01:48

Improve categories modal container

f9a4125

Add modal viewport dimensions

d738268

joomla-cms-bot added the PR-staging label May 12, 2016

cyrez changed the title ~~Modal com categories improve select category~~ Modal com_categories: improve select category May 12, 2016

Remove single "double quote" in token

0fba572

Fix JS error Uncaught SyntaxError: Unexpected token )

96e2bb0

Array indent

6df0bc3

Add edit category as a modal and other improvements

443897d

andrepereiradasilva reviewed May 13, 2016
View reviewed changes

cyrez changed the title ~~Modal com_categories: improve select category~~ Modal com_categories: improve Select & Edit Category buttons May 13, 2016

cyrez changed the title ~~Modal com_categories: improve Select & Edit Category buttons~~ Modal com_categories: improve Select & Edit Category May 13, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 13, 2016

brianteeman added this to the Joomla 3.6.0 milestone May 13, 2016

cyrez mentioned this pull request May 14, 2016

Modal com_contact: improve Select & Edit Contact #10457

Merged

rdeutz merged commit 7fe7c88 into joomla:staging May 16, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016

Uh oh!

Conversation

cyrez commented May 12, 2016 • edited by brianteeman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions (Staging + Multilanguages enabled!)

Uh oh!

andrepereiradasilva commented May 12, 2016

Uh oh!

andrepereiradasilva commented May 12, 2016

Uh oh!

andrepereiradasilva commented May 12, 2016

Uh oh!

cyrez commented May 12, 2016

Uh oh!

joomla-cms-bot commented May 12, 2016

Uh oh!

joomla-cms-bot commented May 12, 2016

Uh oh!

joomla-cms-bot commented May 12, 2016

Uh oh!

cyrez commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrepereiradasilva commented May 12, 2016

Uh oh!

joomla-cms-bot commented May 13, 2016

Uh oh!

cyrez commented May 13, 2016

Uh oh!

andrepereiradasilva May 13, 2016

Choose a reason for hiding this comment

Uh oh!

cyrez May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrepereiradasilva May 13, 2016

Choose a reason for hiding this comment

Uh oh!

cyrez May 13, 2016

Choose a reason for hiding this comment

Uh oh!

andrepereiradasilva commented May 13, 2016

Uh oh!

andrepereiradasilva commented May 13, 2016

Uh oh!

cyrez commented May 13, 2016

Uh oh!

BurtNL commented May 13, 2016

Uh oh!

brianteeman commented May 13, 2016

Uh oh!

cyrez commented May 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cyrez commented May 12, 2016 •

edited by brianteeman

Loading

cyrez commented May 12, 2016 •

edited

Loading

cyrez May 13, 2016 •

edited

Loading