PHP Notice: Undefined variable $data#10985
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Jul 3, 2016
Merged
Conversation
Contributor
Author
|
Another side effect solved by this patch, is that the check that prevents from using external return URLs did not work, of course, as it relied on a variable that didn't exist ($data). Now the check that prevents from using external return URLs has been restored. |
Contributor
|
I have tested this item ✅ successfully on 0112da7 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10985. |
Contributor
|
I have tested this item ✅ successfully on 0112da7 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10985. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10985. |
Member
|
I guess this has to go into 3.6.0 next RC |
Contributor
|
@wilsonge FYI ;) |
Member
|
This has tottaly broken logout redirection... I should have tested... |
Member
|
Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP Notice: Undefined variable: data in [...]/components/com_users/controllers/user.php on line 207.
Testing Instructions
URL if you want to use the component:
http://localhost/index.php?option=com_users&view=login
If you want to use the component again, call the URL:
http://localhost/index.php?option=com_users&view=login and press "logout".
Summary of Changes
The variable $data does not exist. The piece of code that refers to $data has been clearly copied and pasted by the login() method about 120 lines above, but the context of logout() method is slightly different, and does not provide the variable $data as the login() actually does.
Rewritten the related code accordingly.