Skip to content

Release Blocker: After update to Joomla 3.6 RC fails backend files path#10956

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
wojsmol:10955-fix
Jun 29, 2016
Merged

Release Blocker: After update to Joomla 3.6 RC fails backend files path#10956
wilsonge merged 1 commit intojoomla:stagingfrom
wojsmol:10955-fix

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented Jun 29, 2016

Pull Request for Issue #10955 .

Summary of Changes

fix rtrim if site is in document_root on windows

Testing Instructions

  • Install site directly in document_root on windows
  • Check if back-end works.
  • Aplly changes from this PR manualy.
  • Check again if the back-end works.

@wojsmol
Copy link
Copy Markdown
Contributor Author

wojsmol commented Jun 29, 2016

@brianteeman IMHO this is relase blocker

@infograf768
Copy link
Copy Markdown
Member

Tested on MAMP Macintosh in root, i.e. htdocs and this patch does not create an issue here.

@roland-d roland-d added this to the Joomla 3.6.0 milestone Jun 29, 2016
@roland-d
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e34455c

After installation of Joomla 3.6 RC I was unable to see the administrator part, I received a blank page. After applying the patch, the screen is rendered as should be.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10956.

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Jun 29, 2016

I have tested this item ✅ successfully on e34455c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10956.

@joomla-cms-bot joomla-cms-bot changed the title After update to Joomla 3.6 RC fails backend files path Release Blocker: After update to Joomla 3.6 RC fails backend files path Jun 29, 2016
@infograf768
Copy link
Copy Markdown
Member

RTC and changed title to Release blocker


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10956.

@wojsmol
Copy link
Copy Markdown
Contributor Author

wojsmol commented Jun 29, 2016

@infograf768
Copy link
Copy Markdown
Member

RTC again...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10956.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 29, 2016
@joeforjoomla
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e34455c

After the change to JUri::root(null, rtrim(dirname(JUri::base(true)), '/'));
it works fine again on Windows


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10956.

@wilsonge wilsonge merged commit 2523893 into joomla:staging Jun 29, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 29, 2016
@wojsmol wojsmol deleted the 10955-fix branch June 29, 2016 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants