Fix#10724. "List of all tags" menu item incompatible with caching#10728
Conversation
Contributor
|
I have tested this item ✅ successfully on 74ba56d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728. |
1 similar comment
|
I have tested this item ✅ successfully on 74ba56d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728. |
Contributor
|
RTC based on testing. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728. |
Contributor
|
Thanks everybody |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10724
Summary of Changes
Set default value $cachable = false in method display() like in all other core component controllers.
Testing Instructions
by @Giuse69 (corrected by me)
Create a tag A with subtags A1, A2.
Create a tag B with subtags B1, B2.
Create a menu item MENU_A of type "list of all tags" for A to show all tags below A by setting Parent Tag to A.
Create another menu item MENU_B of type "list of all tags" for B to show all tags below B by setting Parent Tag to B.
Enable caching.
Go to frontend and click on MENU_A: you get the list of subtags of A.
Now click on MENU_B. You'll see content of MENU_A (subtags of A, not subtags of B).
Apply patch.
Test again.