Skip to content

Miscellaneous Doc Block Tweaks#10925

Merged
wilsonge merged 5 commits intojoomla:stagingfrom
mbabker:doc-block-urls
Jun 27, 2016
Merged

Miscellaneous Doc Block Tweaks#10925
wilsonge merged 5 commits intojoomla:stagingfrom
mbabker:doc-block-urls

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Jun 24, 2016 •
edited by brianteeman
Loading

Summary of Changes

  • Removes links to the docs wiki for JTable; many of these don't exist or represent the Joomla 1.5 API
  • Changes links for php.net to consistently use the https://secure.php.net mirror
  • Changes all GitHub links to use https to avoid a needless redirect when the API site's docs are compiled
  • Other miscellaneous link updates to remove needless redirects
  • Minor formatting tweaks on some JTable doc blocks (this mostly impacts how some stuff renders when the API site's compiled)

Testing Instructions

Review

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 24, 2016

I have tested this item ✅ successfully on a00e0f3

On review

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 24, 2016

I have tested this item ✅ successfully on a00e0f3

Looks ok from Review.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 24, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 24, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 25, 2016

@mbabker we have a travis error here:

1) JDatabaseIteratorPostgresqlTest::testForEach with data set #0 ('title', '#__dbtest', null, 'stdClass', 0, 0, array(stdClass Object (...), stdClass Object (...), stdClass Object (...), stdClass Object (...)), null)
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => stdClass Object (
-        'title' => 'Testing'
+        'title' => 'Testing2'
     )
     1 => stdClass Object (
-        'title' => 'Testing2'
+        'title' => 'Testing3'
     )
     2 => stdClass Object (
-        'title' => 'Testing3'
+        'title' => 'Testing4'
     )
     3 => stdClass Object (
-        'title' => 'Testing4'
+        'title' => 'Testing'
     )
 )

But the funny thing is this PR just change doc blocks?! Maybe we need just to restart the travis job?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 25, 2016
@ghazal
Copy link
Copy Markdown
Contributor

ghazal commented Jun 25, 2016

I have tested this item ✅ successfully on a00e0f3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 27, 2016

Set back to RTC - no idea why it says there are failures with Travis - it looks ok to me

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10925.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 27, 2016
@wilsonge wilsonge merged commit 7102850 into joomla:staging Jun 27, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 27, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mbabker @brianteeman @zero-24 @ghazal @wilsonge @joomla-cms-bot