[beez3 & other] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10431
Merged
rdeutz merged 11 commits intojoomla:stagingfrom May 16, 2016
Merged
[beez3 & other] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')#10431rdeutz merged 11 commits intojoomla:stagingfrom
rdeutz merged 11 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on cdd4017 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
I have tested this item ✅ successfully on cdd4017 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
|
This PR has received new commits. CC: @alikon, @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
Author
|
Travis was failing on the sysinfo problem that was fixed upstream. |
| <div class="login-greeting"> | ||
| <?php if ($params->get('name') == 0) : ?> | ||
| <?php echo JText::sprintf('MOD_LOGIN_HINAME', htmlspecialchars($user->get('name'))); ?> | ||
| <?php echo JText::sprintf('MOD_LOGIN_HINAME', htmlspecialchars($user->get('name')), ENT_COMPAT, 'UTF-8'); ?> |
Contributor
There was a problem hiding this comment.
Parentheses is in the wrong place.
Contributor
|
@brianteeman please remove the RTC on thsi one to. |
Contributor
|
@zero-24 see zero-24#14 |
|
This PR has received new commits. CC: @alikon, @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
seems fine to me now. |
Contributor
Author
|
Back to Pending. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
|
This PR has received new commits. CC: @alikon, @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
I have tested this item ✅ successfully on 2f4ef51 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
I have tested this item ✅ successfully on 2f4ef51 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10431. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions
Please do a code review or test all changed files.