Skip to content

SEF mode Links from Numeric Tag Won't work in Popular Tags module#10693

Merged
roland-d merged 1 commit intojoomla:stagingfrom
wojsmol:10689-fix
Jun 25, 2016
Merged

SEF mode Links from Numeric Tag Won't work in Popular Tags module#10693
roland-d merged 1 commit intojoomla:stagingfrom
wojsmol:10689-fix

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented May 31, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #10689
Original issue description

Steps to reproduce the issue

Create a numeric tag in an article and create a new Popular Tags module, using the cloud display option.

Expected result

Display an article which is tagged by the numeric tag.

Actual result

404 Error

System information (as much as possible)

Joomla 3.5.1/php 7.0/mysql 5.7.11/ SEF mode

Additional comments

To correct this, modify modules/mod_tags_popular/tmpl/cloud.php, line 46 should contain
...$item->tag_id . '-' . $item->alias)...
instead of
...$item->tag_id . ':' . $item->alias)...

@wojsmol wojsmol mentioned this pull request May 31, 2016
Closed
@RonakParmar
Copy link
Copy Markdown

RonakParmar commented Jun 2, 2016

Please provide some more information to reproduce the issue.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10693.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 10, 2016

I have tested this item ✅ successfully on e2ed809

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10693.

@anjahage
Copy link
Copy Markdown

anjahage commented Jun 25, 2016

I have tested this item ✅ successfully on e2ed809

Reproduced the issue and tested succesfully. After applying the patch I don't get a 404 error anymore.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10693.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 25, 2016

RTC based on testing

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10693.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 25, 2016
@roland-d roland-d added this to the Joomla 3.6.0 milestone Jun 25, 2016
@roland-d roland-d merged commit e5a38ac into joomla:staging Jun 25, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 25, 2016
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jun 25, 2016

Thanks everybody

@wojsmol wojsmol deleted the 10689-fix branch June 25, 2016 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

7 participants

@wojsmol @RonakParmar @brianteeman @anjahage @zero-24 @roland-d @joomla-cms-bot