Conversation
|
Looks like there was a couple of things missed between the clean up of the phpcs 1.5.x rules and the PHPCS 2.x rules. Here is what should happen based on the decisions from the phpcs2.x development.
As for PEAR.Functions.ValidDefaultValue, that exclusion is needed. Historically we have included that sniff. Although we don't have it written out that function "Arguments with default values must be at the end of the argument list"; we do extend from the PEAR standard. I'm inclined to say that we should refactor that function or exclude the single file that's causing issues. Another option would be to implement an exclusion for |
|
@photodude |
|
I don't think that other comit needs to be reverted, just remove The other change for |
|
@photodude done |
|
These corrections look good to me. @wilsonge |
|
cc @wilsonge |
|
RTC based on the green mark by travis Thanks ;) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10834. |
|
btw: what is wrong with |
Pull Request for improvment .
Summary of Changes
Testing Instructions
Check if travis still passes
Additional comments
I modified the exclusion for
PEAR.Functions.ValidDefaultValueexclude pattern due to the result of this travis build https://travis-ci.org/wojsmol/joomla-cms/jobs/137958211cc @wilsonge @photodude