[com_config] Error?/Success? messages on save#10425

Merged

rdeutz merged 3 commits intojoomla:stagingfrom

andrepereiradasilva:com_config-save-messages-ux

May 16, 2016

Contributor

andrepereiradasilva commented May 11, 2016 •

edited by brianteeman

Loading

Summary of Changes

In com_config when we get an error on save (ex: bad session token or no permission) we get a green (aka success) message.

This is a bad UX problem:

Green messages are for success
Blue messages are for information
Yellow messages are for warnings
Red messages are for errors or very importing stuff

This PR corrects that.

Testing Instructions

Code review, or, for instance:

(browser Tab 1) Go to global config form, don't save
(browser Tab 2) Open a new browser tab, go to backend, logout and login again
(browser Tab 1) Press "Save" or "Save and Close" in the global config to save.
You'll notice you get and invalid token message and the message is green and from a user perspective it's associated with action success.
Apply patch, repeat process 1 to 3. Now the message is red.

andrepereiradasilva added 3 commits

May 10, 2016 15:02


          Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging

6d52fd4


          Merge branch 'staging' of https://github.com/andrepereiradasilva/joom…

5e7eeb0

…la-cms into staging


          error red color for error, green message for success

d7b3fdb

joomla-cms-bot added the PR-staging label

Contributor

brianteeman commented May 11, 2016

I have tested this item ✅ successfully on d7b3fdb

Good find

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.}

BurtNL commented May 11, 2016

I have tested this item ✅ successfully on d7b3fdb

Works as described.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.}

Contributor

brianteeman commented May 11, 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.}

joomla-cms-bot added the RTC label

brianteeman added this to the Joomla 3.6.0 milestone

Contributor Author

andrepereiradasilva commented May 11, 2016

@brianteeman @BurtNL thanks for testing!

Member

richard67 commented May 11, 2016

I have tested this item ✅ successfully on d7b3fdb

Works as described.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.}

Member

richard67 commented May 11, 2016

I was a bit late I just see 😄

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.}

Contributor Author

andrepereiradasilva commented May 11, 2016

thanks @richard67 another test in always good 😄

Contributor

brianteeman commented May 11, 2016

all tests always welcome

On 11 May 2016 at 17:51, Richard Fath notifications@github.com wrote:

I was a bit late I just see [image: 😄]

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10425
https://issues.joomla.org/tracker/joomla-cms/10425.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10425 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Member

richard67 commented May 11, 2016

I will soon (in a few days) need testers for PR I am preparing, make utf8mb4 conversion use files with version numbers so not on every change all has to run, and make it handle extensions, too, so I am also working on a PR for weblinks to provide an example. Testers will be welcome, I'll let you know when my PR is ready.

rdeutz merged commit 09b624c into joomla:staging

joomla-cms-bot removed the RTC label

andrepereiradasilva deleted the com_config-save-messages-ux branch

May 16, 2016 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet