Skip to content

Honcho PR map: cleanup pass #32863

@erosika

Description

@erosika

Honcho PR Map: Cleanup Pass

Context

This issue is a cleanup map for the current open Honcho PR cluster: pick one canonical PR per bug cluster, merge/rebase that, then close duplicates with a Superseded by #NNN link.

This is not meant to be an exhaustive audit of every Honcho search hit. It is a maintainer path through the pile.

Current highest-priority path

1. Security / config hygiene

2. Runtime identity / peer mapping

Canonical: #30077.

#30077 now carries the runtime peer mapping path and should be treated as the canonical identity/perspective correctness PR.

It covers:

Do not fold these into #30077:

3. Peer cards / No profile facts

Canonical: #27979, adopted into local #30077 work with authorship preserved.

#17124, #31240, and #27979 all address the same direct target peer-card fallback cluster. Prefer #27979 because it includes both:

  • direct target peer-card fallback, and
  • peer-card read/write path alignment.

#31240 is narrower and includes .paperclip_artifacts/candidate-skip-ledger.jsonl; do not adopt it directly. #17124 includes merge commits and an older fallback shape.

#23485 is also a good fit: it aligns honcho_context(peer="user") perspective with the same observer/target resolution model.

Local validation performed against #30077 + #27979 + #23485:

  • scripts/run_tests.sh tests/honcho_plugin/test_session.py tests/test_honcho_session_context.py tests/honcho_plugin/test_pin_peer_name.py tests/honcho_plugin/test_cli.py tests/run_agent/test_memory_provider_init.py tests/gateway/test_agent_cache.py
  • Result: 251 passed, 0 failed.

After #27979/#23485 are pushed into #30077, #30077 should also close/supersede:

4. Multimodal sync crash

Canonical: #32030.

Recommendation: prefer #32030; close #22768/#30264/#30294 if #32030 covers their tests.

5. Self-hosted / base URL / local auth

Keep these as separate sub-bugs unless a clean self-hosted umbrella PR appears:

6. Session naming / path normalization

These are small enough to merge independently after freshness checks.

Secondary clusters

Startup/lifecycle reliability

Recommendation: keep #24763 and #31664 narrow. Treat #24847/#19102 as startup-latency/fail-open work; verify against the current lazy/session-init path.

Tool correctness / budgets / schemas

Prioritize #29403 and #4523 because they affect runtime correctness/tool availability.

Memory-context leakage / prompt hygiene

Some of these are broader memory-provider/prompt-assembly hygiene, not Honcho-only. Pick one canonical boundary rule for memory-context handling, then close narrower duplicates.

Session writes / metadata / write frequency

Compare #18536, #19650, and #9422 before merging; they may touch the same write path from different angles.

Plugin migration / setup compatibility

Only merge if current setup flows still break for users upgrading from old Honcho config paths. Otherwise close as stale migration cleanup.

Optional/session-sharing features

Defer until #30077 settles the core identity mapping semantics.

Suggested cleanup order

  1. Land fix(security): apply 0600 permissions on memory plugin config files containing API keys #32244 for config permissions.
  2. Land fix(honcho): runtime peer mapping — correctness follow-ups + setup wizard + docs #30077 as the canonical runtime identity + peer perspective cleanup.
  3. After fix(honcho): runtime peer mapping — correctness follow-ups + setup wizard + docs #30077 lands, close duplicate/superseded PRs:
  4. Land fix(memory): normalize multimodal sync content #32030 for multimodal sync; close fix(honcho): sync_turn crashes on list input from image-bearing messages #22768/fix(honcho): flatten multimodal list content in sync_turn (#30252) #30264/fix(honcho): flatten multimodal list content in sync_turn (#30252) #30294 if covered.
  5. Work self-hosted issues independently: fix(honcho): support base_url-only config in cmd_identity for local instances #13439, fix(honcho): honor host-specific baseUrl #14489, fix(plugins/honcho): strip version prefix from base_url for self-hosted instances (#20688) #20720, feat(honcho): prompt for local JWT during self-hosted setup #30180, fix(honcho): use safe profile host keys #26478.
  6. Land small independent reliability fixes: fix(plugins): cap Honcho session name to 100 chars to prevent API errors (#13868) #15380, fix(honcho): normalize manual cwd overrides #23256, fix(honcho): prevent TOCTOU race in get_honcho_client() #24763, fix: shut down Honcho memory provider after oneshot #31664.
  7. Treat memory-context/prompt hygiene as a separate cleanup track.

At a glance

Cluster Canonical PR Related issue(s) Supersede / close candidates
Config security #32244, #24458 #4074
Runtime peer mapping #30077 #27314, #28283 #27371, #28572, #21539, #15598
Peer cards / context perspective #27979 + #23485 in #30077 #31219 #17124, #31240, #23022, #20729
API-server identity headers #24423 keep separate / companion
Multimodal sync #32030 #30252 #22768, #30264, #30294
Self-hosted base URL #13439, #14489, #20720 #2613, #4269, #20688 older base_url retries if covered
Local JWT #30180 #29885
Safe host keys #26478 #26459, #30246
Session naming/path #15380, #23256 #13868, #13284 older cwd/path variants
Startup lifecycle #24763, #24847, #31664, #19102 #24759, #5726 overlapping lazy-startup variants
Memory-context hygiene #33248, #23393, #32031 #13631 narrower tag-scrub duplicates
Tool correctness #29403, #16133 #29402, #17968, #8920, #4523

Status note: PR mergeability and cherry-pick viability must be rechecked immediately before merging/closing anything.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low — cosmetic, nice to havecomp/pluginsPlugin system and bundled pluginstool/memoryMemory tool and memory providerstype/refactorCode restructuring, no behavior change

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions