fix(honcho): support base_url-only config in cmd_identity for local instances#13439
Open
ygd58 wants to merge 1 commit into
Open
fix(honcho): support base_url-only config in cmd_identity for local instances#13439ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
…nstances cmd_identity() only checked _resolve_api_key(), blocking local Honcho instances that use base_url instead of an API key (issue NousResearch#2613). Changes to plugins/memory/honcho/cli.py: - Add _resolve_base_url() helper: reads baseUrl/base_url from host block and root level (camelCase + snake_case) - Add _is_configured() helper: returns True if api_key OR base_url is set — any valid auth method suffices - cmd_identity(): use _is_configured() instead of _resolve_api_key() so local no-auth instances can use the command Rebased from NousResearch#2619 to target current plugins/memory/honcho/ layout after honcho_integration/ was moved in refactor NousResearch#4623. Fixes NousResearch#2613
Collaborator
|
Rebased from #2619 (closed) onto current plugins/memory/honcho/ layout after pluggable memory refactor. |
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local Honcho instances using
base_urlinstead of an API key could not usehermes honcho identity— it required an API key and exited early with "No API key configured".Fix
Adds to
plugins/memory/honcho/cli.py:_resolve_base_url()helper: readsbaseUrl/base_urlfrom host block and root level (camelCase + snake_case)_is_configured()helper: returnsTrueif eitherapi_keyORbase_urlis setcmd_identity(): uses_is_configured()instead of_resolve_api_key()onlyNote
Rebased from #2619 to target the current
plugins/memory/honcho/layout afterhoncho_integration/was moved in the pluggable memory provider refactor (#4623).Fixes #2613