fix(honcho): support base_url for local instances in setup and identity commands#2619
Closed
ygd58 wants to merge 1 commit into
Closed
fix(honcho): support base_url for local instances in setup and identity commands#2619ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
1 task
This was referenced Mar 23, 2026
Contributor
|
Thanks for the contribution, @ygd58! Closing this as stale. The If you want to revisit this for the refactored code on current main, please open a new PR rebased on main targeting the current file layout. Your authorship will be preserved through cherry-pick if we salvage any of your work. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2613
Problem
Local Honcho instances using
base_urlinstead of an API key couldn't usehermes honcho setuporhermes honcho identity— both required an API key and exited early.Additionally,
base_urlfrom the host block was not read (only root-levelbaseUrlwas checked, notbase_urlsnake_case).Fix
honcho_integration/client.py:base_urlandbaseUrlfrom both host block and root level (snake_case + camelCase)honcho_integration/cli.py:_resolve_base_url()helper_is_configured()helper (API key OR base_url)cmd_setup(): allow continuing without API key if base_url is configuredcmd_identity(): use_is_configured()instead of_resolve_api_key()only