Skip to content

fix(honcho): align user context peer perspective#23485

Closed
cmullins70 wants to merge 1 commit into
NousResearch:mainfrom
cmullins70:fix/honcho-user-context-peer-perspective
Closed

fix(honcho): align user context peer perspective#23485
cmullins70 wants to merge 1 commit into
NousResearch:mainfrom
cmullins70:fix/honcho-user-context-peer-perspective

Conversation

@cmullins70

@cmullins70 cmullins70 commented May 11, 2026

Copy link
Copy Markdown

Summary

  • Fix Honcho session-context lookups so peer="user" uses the same observer/target resolution as explicit configured peer IDs.
  • Prevent the user alias from querying from the user self-perspective when the assistant-observed representation is the one with durable memory.
  • Add regression tests for user alias, explicit peer, and self-observer fallback behavior.

Test Plan

  • ./scripts/run_tests.sh tests/test_honcho_session_context.py tests/test_honcho_client_config.py

fix(honcho): align user context peer perspective
74d0f4b 
Use the shared observer/target resolver for session context so peer='user' and explicit configured peer IDs query Honcho from the same assistant-observed perspective when allowed. Add regression coverage for user alias, explicit peer, and self-observer fallback.
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 11, 2026
This was referenced May 26, 2026
Open
Merged
@teknium1

teknium1 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This appears to be implemented on current main already.

Automated hermes-sweeper review evidence:

  • plugins/memory/honcho/session.py:1010 now uses _resolve_observer_target(session, peer) inside get_session_context() and passes peer_target=target_peer_id or observer_peer_id plus peer_perspective=observer_peer_id to honcho_session.context().
  • plugins/memory/honcho/session.py:1060 defines the shared observer/target resolver: assistant-observed target context when ai_observe_others is enabled, otherwise self-observer fallback.
  • tests/test_honcho_session_context.py:55 and tests/test_honcho_session_context.py:70 include regression coverage for the peer="user" alias and explicit user peer behavior.
  • The implementation landed as bcae3fcc4e0db772560ed64c59047503b1cb5629 (fix(honcho): align user context peer perspective), which is contained in v2026.5.28 and later tags.

Closing as implemented on main. Thanks for the fix and tests.

@teknium1 teknium1 closed this Jun 11, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmullins70 @teknium1 @alt-glitch