fix(honcho): respect writeFrequency in sync_turn#19650
Open
starship-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Honcho's
writeFrequencysetting is the user's control for when completed conversation turns are written to Honcho: immediately, asynchronously, at session end, or every N turns. This matters for users who intentionally defer or batch writes, especially for session-end or cadence-based memory syncing.The
sync_turn()path was appending the turn and then calling_flush_session()directly. That bypassedHonchoSessionManager.save(), which is wherewriteFrequencyrouting is applied. As a result, deferred modes such assessionand integer cadences could silently behave like per-turn writes.Change
sync_turn()persistence throughHonchoSessionManager.save()so configuredwriteFrequencymodes are honored.async,turn,session, and integer write-frequency routing fromsync_turn().Why this approach
HonchoSessionManager.save()already centralizes the write-frequency decision. Routingsync_turn()through it keeps the completed-turn sync path consistent with the rest of the Honcho session manager, while preserving immediate flushing for modes that are supposed to flush immediately.This keeps the fix narrow: one routing change plus tests for each supported write-frequency mode.
Test Plan
python -m pytest tests/honcho_plugin/test_sync_turn_write_frequency.py tests/honcho_plugin/test_async_memory.py -q(45 passed)python -m pytest tests/honcho_plugin -q(271 passed)