Skip to content

fix(honcho): normalize manual cwd overrides#23256

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/13284-honcho-cwd-normalize
Open

fix(honcho): normalize manual cwd overrides#23256
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/13284-honcho-cwd-normalize

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

What does this PR do?

This fixes #13284 with a narrow bugfix that keeps the affected path aligned with the current Hermes behavior without widening the change surface.

Related Issue

Fixes #13284

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • normalize manual Honcho cwd overrides before comparing them to session cwd values
  • add regression coverage for equivalent cwd spellings that should resolve to the same manual override
  • Files: plugins/memory/honcho/client.py, tests/honcho_plugin/test_async_memory.py

How to Test

  1. Run uv run --frozen pytest -q -o addopts='' tests/honcho_plugin/test_async_memory.py -k 'manual_override_matches_equivalent_cwd_spelling or manual_beats_session_id'
  2. Run uv run --frozen ruff check plugins/memory/honcho/client.py tests/honcho_plugin/test_async_memory.py
  3. Confirm the affected workflow in Bug: Honcho session override lookup misses configured cwd when path spelling changes #13284 now follows the expected behavior.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

Screenshots / Logs

Honcho override regression tests and Ruff checks passed locally on macOS.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists labels May 10, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #13333 — same Honcho cwd normalization fix for #13284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Honcho session override lookup misses configured cwd when path spelling changes

2 participants