Skip to content

feat(honcho): surface pinPeerName in setup and status (#28283)#28572

Closed
wesleysimplicio wants to merge 1 commit into
NousResearch:mainfrom
wesleysimplicio:codex/feat-28283-honcho-pin-peer-name-surface
Closed

feat(honcho): surface pinPeerName in setup and status (#28283)#28572
wesleysimplicio wants to merge 1 commit into
NousResearch:mainfrom
wesleysimplicio:codex/feat-28283-honcho-pin-peer-name-surface

Conversation

@wesleysimplicio

@wesleysimplicio wesleysimplicio commented May 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR makes the existing pinPeerName setting visible at the two places where users most need it: initial setup and status inspection.

Root cause

The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.

Fix

  • introduce the smallest surface needed for the new capability in the touched subsystem
  • preserve existing behavior and defaults outside the new entry point or configuration path
  • cover the new path with focused validation before asking for review

Why this shape

This shape mirrors #29640 so reviewers can quickly compare scope, root cause, fix, tests, and related context without having to decode a custom PR description.

Tests

  • Veja a descrição original preservada abaixo para detalhes de validação, testes e notas de verificação.
Original body

Related PRs / issues

Fixes #28283

Original body

Summary

This PR makes the existing pinPeerName setting visible at the two places where users most need it: initial setup and status inspection.

What Changed

  • Standardized this PR body to the current Hermes Turbo template.
  • Preserved the original detailed description below for reference.

Fluxo

A mudança continua seguindo o fluxo original descrito na seção preservada abaixo, sem ampliar o escopo funcional deste PR.

Visão

A padronização melhora a revisão, reduz ruído e evita deriva de formatação entre PRs abertos.

Test Plan

  • Veja a descrição original preservada abaixo para detalhes de validação, testes e notas de verificação.
Original body

What does this PR do?

This PR makes the existing pinPeerName setting visible at the two places where users most need it: initial setup and status inspection.

The underlying pinPeerName fix already exists and solves a real multi-instance Honcho problem: a single human using Hermes across multiple front-ends can otherwise get split into multiple Honcho peers.

What is missing today is discoverability:

  • hermes memory setup does not surface the setting when the user is configuring Honcho
  • hermes honcho status does not show the effective value, which makes diagnosis harder when memory appears fragmented across devices

This change is intentionally a discoverability + diagnostics improvement around an already-correct runtime capability (no runtime identity rule changes, no default flips).

Solution Sketch

  • introduce the smallest surface needed for the new capability in the touched subsystem
  • preserve existing behavior and defaults outside the new entry point or configuration path
  • cover the new path with focused validation before asking for review

Related Issue

Fixes #28283

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • added a setup-wizard prompt that explains when pinPeerName should be enabled (plugins/memory/honcho/cli.py)
  • persisted that choice into the active Honcho host config (plugins/memory/honcho/cli.py)
  • surfaced the effective pinPeerName value in hermes honcho status (plugins/memory/honcho/cli.py)
  • added regression coverage for the setup+status surface area (tests/honcho_plugin/test_cli.py)

How to Test

  1. Run python -m pytest tests/honcho_plugin/test_cli.py -q -n 4.
  2. Run hermes memory setup and confirm the prompt surfaces pinPeerName with a clear explanation.
  3. Run hermes honcho status and confirm it prints the effective pinPeerName value.

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

  • N/A (CLI change). If needed, I can attach a hermes memory setup capture and a hermes honcho status output snippet.

Generated by Hermes Turbo


Generated by Hermes Turbo

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers labels May 19, 2026
@wesleysimplicio

Copy link
Copy Markdown
Contributor Author

Closing non-fix PR as requested — mantendo apenas PRs de fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface pinPeerName in hermes memory setup wizard for multi-instance Honcho setups

2 participants