feat(honcho): surface pinPeerName in setup and status (#28283)#28572
Closed
wesleysimplicio wants to merge 1 commit into
Closed
feat(honcho): surface pinPeerName in setup and status (#28283)#28572wesleysimplicio wants to merge 1 commit into
wesleysimplicio wants to merge 1 commit into
Conversation
This was referenced May 26, 2026
Contributor
Author
|
Closing non-fix PR as requested — mantendo apenas PRs de fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the existing
pinPeerNamesetting visible at the two places where users most need it: initial setup and status inspection.Root cause
The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.
Fix
Why this shape
This shape mirrors #29640 so reviewers can quickly compare scope, root cause, fix, tests, and related context without having to decode a custom PR description.
Tests
Original body
Related PRs / issues
Fixes #28283
Original body
Summary
This PR makes the existing
pinPeerNamesetting visible at the two places where users most need it: initial setup and status inspection.What Changed
Fluxo
A mudança continua seguindo o fluxo original descrito na seção preservada abaixo, sem ampliar o escopo funcional deste PR.
Visão
A padronização melhora a revisão, reduz ruído e evita deriva de formatação entre PRs abertos.
Test Plan
Original body
What does this PR do?
This PR makes the existing
pinPeerNamesetting visible at the two places where users most need it: initial setup and status inspection.The underlying
pinPeerNamefix already exists and solves a real multi-instance Honcho problem: a single human using Hermes across multiple front-ends can otherwise get split into multiple Honcho peers.What is missing today is discoverability:
hermes memory setupdoes not surface the setting when the user is configuring Honchohermes honcho statusdoes not show the effective value, which makes diagnosis harder when memory appears fragmented across devicesThis change is intentionally a discoverability + diagnostics improvement around an already-correct runtime capability (no runtime identity rule changes, no default flips).
Solution Sketch
Related Issue
Fixes #28283
Type of Change
Changes Made
pinPeerNameshould be enabled (plugins/memory/honcho/cli.py)plugins/memory/honcho/cli.py)pinPeerNamevalue inhermes honcho status(plugins/memory/honcho/cli.py)tests/honcho_plugin/test_cli.py)How to Test
python -m pytest tests/honcho_plugin/test_cli.py -q -n 4.hermes memory setupand confirm the prompt surfacespinPeerNamewith a clear explanation.hermes honcho statusand confirm it prints the effectivepinPeerNamevalue.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
hermes memory setupcapture and ahermes honcho statusoutput snippet.Generated by Hermes Turbo
Generated by Hermes Turbo