fix(honcho): make startup fail open#24847
Merged
teknium1 merged 2 commits intoJun 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the Honcho memory provider fail open during Hermes startup when network-backed session creation is slow, unavailable, or stuck in Honcho peer setup. Context and hybrid modes now resolve the session key without network I/O, start session setup in a daemon thread, and return empty memory context until Honcho is ready instead of blocking agent construction.
The change preserves the existing tools-mode contracts: lazy tools mode still waits for the first Honcho tool call before initializing, while
init_on_session_start=trueremains eager and ready on return when startup succeeds.Related Issue
Fixes #5726
Type of Change
Changes Made
plugins/memory/honcho/__init__.py_session_ready()so hooks do not use a manager that was assigned beforeget_or_create()and startup setup completed.prefetch,queue_prefetch,sync_turn, andon_memory_write.on_session_endandshutdownwhile background init is still in flight.tests/test_honcho_startup_fail_open.pyDuplicate search before opening found #5726 as the matching open issue. No open competing PRs were found for
_do_session_init,HonchoSessionManager.get_or_create,Honcho session is still initializing, or Honchoadd_peers. Related open PR #2164 is a stale tools-mode startup-context feature, not this fail-open fix.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A, this PR does not add a skill.
Screenshots / Logs
Infographic