fix(honcho): preserve memory when backend rejects conclusions#26484
Open
atmigtnca wants to merge 1 commit into
Open
fix(honcho): preserve memory when backend rejects conclusions#26484atmigtnca wants to merge 1 commit into
atmigtnca wants to merge 1 commit into
Conversation
Collaborator
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two Honcho memory reliability failures seen in normal Hermes sessions:
sync_turnnow normalizes structured/multimodal message content before callingsanitize_context, so image/audio/list-style provider payloads do not raiseTypeError: expected string or bytes-like object, got 'list'and drop the whole turn.honcho_concludenow preserves explicit durable facts in the target peer card when a self-hosted Honcho backend can store/search raw messages but rejects conclusion creation because backend LLM credentials are missing.The fallback keeps the same observer/target relationship used by the normal conclusion path and deduplicates the fact before appending it to the peer card.
Related Issue
No linked GitHub issue.
Related open PRs found while checking for duplicates:
sync_turncrash only.Type of Change
Changes Made
plugins/memory/honcho/__init__.py_content_to_text()to coerce strings, dicts, and OpenAI-style content lists into safe text before Honcho ingest.[image attachment]and[audio attachment].plugins/memory/honcho/session.pytests/honcho_plugin/test_session.pysync_turnnormalization.How to Test
python -m pytest tests/honcho_plugin/test_session.py -q -o 'addopts='git diff --checkpython -m compileall -q plugins/memory/honcho tests/honcho_pluginpython -m ruff check plugins/memory/honcho/__init__.py plugins/memory/honcho/session.py tests/honcho_plugin/test_session.pyFull-suite note: I also attempted
scripts/run_tests.shfor CI parity. It reached 93% before the 600s local command timeout and had unrelated failures outside this Honcho change area, so this PR reports the focused checks above rather than claiming a full-suite pass.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs