fix: harden honcho memory and dashboard terminal#24270
Open
florianaebi wants to merge 1 commit into
Open
Conversation
19 tasks
austinpickett
requested changes
May 19, 2026
austinpickett
left a comment
Collaborator
There was a problem hiding this comment.
Please fix merge conflicts and use .github/PULL_REQUEST_TEMPLATE.md
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Honcho memory prefetch/sync behavior and improves the dashboard’s embedded terminal experience by making theming/font rendering more robust while removing the WebGL xterm path.
Changes:
- Cap first-turn Honcho dialectic prefetch wait time and expand “trivial prompt” detection (including greetings) to skip unnecessary prefetch.
- Coerce structured/multimodal turn content to text before Honcho memory sanitization to avoid background-thread failures.
- Align branding/theme behavior across dashboard + TUI; improve dashboard xterm font fallbacks and remove the unused WebGL addon dependency.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/src/pages/ChatPage.tsx | Switch terminal theming to derive from dashboard theme, expand font fallbacks for glyph coverage, and disable WebGL addon usage. |
| web/package.json | Remove @xterm/addon-webgl dependency. |
| web/package-lock.json | Remove @xterm/addon-webgl lockfile entries. |
| ui-tui/src/components/branding.tsx | Use theme-provided brand name instead of hard-coded strings. |
| plugins/memory/honcho/init.py | Add first-turn timeout cap helper, broaden trivial prompt regex, and coerce non-string content before sanitization. |
| tests/honcho_plugin/test_session.py | Add tests for first-turn timeout cap and greeting trivial-prompt behavior. |
| tests/agent/test_memory_provider.py | Add regression test for coercing structured content before sanitization. |
Files not reviewed (1)
- web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1175
to
+1181
| msg_limit = self._config.message_max_chars if self._config else 25000 | ||
| clean_user_content = sanitize_context(user_content or "").strip() | ||
| clean_assistant_content = sanitize_context(assistant_content or "").strip() | ||
| clean_user_content = sanitize_context( | ||
| self._coerce_content_for_memory(user_content) | ||
| ).strip() | ||
| clean_assistant_content = sanitize_context( | ||
| self._coerce_content_for_memory(assistant_content) | ||
| ).strip() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Note: direct push to NousResearch/hermes-agent:main was denied for florianaebi, so this branch was pushed to the fork.