fix: write Honcho peer cards with observer target#23022
Closed
claudeo45 wants to merge 1 commit into
Closed
Conversation
Collaborator
19 tasks
9 tasks
This was referenced May 26, 2026
Contributor
|
Automated hermes-sweeper review: this looks implemented on current main. Evidence:
Thanks for the clear repro and test; the maintainer comment noting this as a duplicate of #20729/#17186 matches the fix now present on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: write Honcho peer cards with observer target
Summary
HonchoSessionManager.set_peer_card()so it writes peer cards through the same observer/target relationship used byget_peer_card().set_peer_card(..., peer="user")callsassistant_peer.set_card(card, target=user_peer_id)when AI-observes-user mode is enabled.Bug
In AI-observes-user mode, peer-card reads use the assistant observer with a user target, e.g.:
Before this patch, peer-card writes resolved only the target peer and called:
That made
honcho_profile(card=[...], peer="user")report success while a subsequenthoncho_profile(peer="user")could still return an empty card, because the read and write paths addressed different Honcho card scopes.Fix
set_peer_card()now uses_resolve_observer_target()and writes to the observer peer with the resolved target:It falls back to bare
set_card(card)only when there is no separate target, matching the existing read-side behavior.Verification
Ran:
Results:
Local reproduction observed
A one-time Honcho backfill created conclusions successfully, and
honcho_search/honcho_reasoningcould see them. Buthoncho_profile(peer="user")returned an empty profile even afterhoncho_profile(card=[...], peer="user")returned success. After this patch and a fresh Hermes process,honcho_profile(peer="user")returned the seeded facts correctly.