Skip to content

fix(honcho): use safe profile host keys#26478

Closed
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix-honcho-profile-host-key
Closed

fix(honcho): use safe profile host keys#26478
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix-honcho-profile-host-key

Conversation

@aqilaziz

@aqilaziz aqilaziz commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • derive profile-scoped Honcho host keys with underscores so fallback workspace IDs match Honcho's ID regex
  • keep reading legacy dot-form host blocks and migrate them when CLI writes profile-scoped config
  • update profile rename handling, docs, and regression tests
  • include CI stabilizers for Discord e2e mocks and Nous provider parity tests

Fixes #26459

Tests

  • python -m ruff check plugins\memory\honcho\client.py plugins\memory\honcho\cli.py hermes_cli\profiles.py tests\honcho_plugin\test_client.py tests\honcho_plugin\test_cli.py tests\hermes_cli\test_profiles.py tests\e2e\conftest.py tests\run_agent\test_provider_parity.py
  • python -m pytest -o addopts= tests\honcho_plugin -q --tb=short
  • python -m pytest -o addopts= tests\hermes_cli\test_profiles.py -q --tb=short
  • python -m pytest -o addopts= tests\e2e\test_discord_adapter.py -q --tb=short
  • python -m pytest -o addopts= tests\run_agent\test_provider_parity.py::TestDeveloperRoleSwap::test_developer_role_via_nous_portal tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_includes_nous_product_tags tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_uses_chat_completions_format -q --tb=short
  • python -m py_compile plugins\memory\honcho\client.py plugins\memory\honcho\cli.py hermes_cli\profiles.py
  • git diff --check

@alt-glitch alt-glitch added P3 Low — cosmetic, nice to have type/bug Something isn't working comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers labels May 15, 2026
@aqilaziz aqilaziz force-pushed the fix-honcho-profile-host-key branch from a8fd5b0 to cc2790d Compare May 15, 2026 22:42
This was referenced May 16, 2026
Closed
Closed
Closed
This was referenced May 26, 2026
Open
Closed
@kshitijk4poor kshitijk4poor mentioned this pull request May 30, 2026
Merged
@teknium1

teknium1 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This looks implemented on current main. This is an automated hermes-sweeper review.

Evidence:

  • 827ce602dbed199f665f3975b61303aace2963ea (fix(honcho): harden self-hosted setup paths) explicitly closes _host_key() returns dot-separated form ("hermes.fundraising") that violates Honcho workspace ID regex #26459 and includes the Honcho profile-host-key fix.
  • plugins/memory/honcho/client.py:36 defines profile_host_key(), which returns safe hermes_<profile> keys instead of dot-form hermes.<profile> keys.
  • plugins/memory/honcho/client.py:44 preserves compatibility by reading legacy hermes.<profile> host blocks when resolving a new underscore-form host.
  • hermes_cli/profiles.py:1533 updates profile rename migration to handle both hermes_<old> and legacy hermes.<old> host blocks and write the renamed hermes_<new> block.
  • The gateway hardening from this PR's second commit is also present at hermes_cli/gateway.py:2292, where inaccessible service PATH directories are ignored by catching OSError.
  • The Honcho fix is contained in release tag v2026.6.5.

@teknium1 teknium1 closed this Jun 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

_host_key() returns dot-separated form ("hermes.fundraising") that violates Honcho workspace ID regex

3 participants

@aqilaziz @teknium1 @alt-glitch