fix(honcho): reject whitespace-only honcho_search and honcho_reasoning queries#11256
Open
fjlaowan1983 wants to merge 1 commit into
Open
fix(honcho): reject whitespace-only honcho_search and honcho_reasoning queries#11256fjlaowan1983 wants to merge 1 commit into
fjlaowan1983 wants to merge 1 commit into
Conversation
Strip query before validation; add regression tests (aligns upstream NousResearch#11192). Made-with: Cursor
Collaborator
|
Likely duplicate of #11192 — same fix: reject whitespace-only queries for honcho_search and honcho_reasoning. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryforhoncho_searchandhoncho_reasoningwith(args.get("query") or "").strip()before calling Honcho APIs.tool_errorshape as an emptyquery:Missing required parameter: query.tests/honcho_plugin/test_session.py(TestConcludeToolDispatch) asserting the backend methods are not invoked for whitespace-only input.Context
Related upstream discussion / radar: #11192 (
fix(honcho): reject whitespace-only tool queries).Test plan
python -m pytest tests/honcho_plugin/test_session.py::TestConcludeToolDispatch -v -o addopts=Noticed this while setting up uv on Windows WSL2 — trivial guard, but it avoids pointless Honcho calls when the model sends blank queries.