fix(honcho): reject whitespace-only tool queries#11192
Closed
0xKingBack wants to merge 1 commit into
Closed
Conversation
Normalize honcho_search and honcho_reasoning query inputs with strip() so whitespace-only values fail fast as missing required parameters, matching conclude input hygiene. Made-with: Cursor
fjlaowan1983
added a commit
to fjlaowan1983/hermes-agent
that referenced
this pull request
Apr 16, 2026
Strip query before validation; add regression tests (aligns upstream NousResearch#11192). Made-with: Cursor
1 task
Collaborator
|
Likely duplicate of #11256 — same fix: reject whitespace-only query in honcho_search and honcho_reasoning. |
Contributor
Author
|
Thanks for the heads up, @alt-glitch! I just noticed #11256 covers the same edge cases for Honcho queries and even includes slightly more comprehensive validation. To keep the PR queue clean, I'll close this one in favor of #11256. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
honcho_searchandhoncho_reasoningqueryinputs withstrip()before validationqueryas missing required parameter to match existinghoncho_concludeinput hygienequeryin both tool pathsTest plan
python -m pytest tests/honcho_plugin/test_session.py -q -o addopts=