fix: shut down Honcho memory provider after oneshot#31664
Open
benpret wants to merge 1 commit into
Open
Conversation
Ensure oneshot runs memory-provider shutdown in a finally block so background Honcho work is drained before process exit. Route Honcho provider shutdown through the session manager, flush pending sessions for all write-frequency modes, and join tracked context-prefetch threads. Tests cover oneshot provider shutdown, session-mode flush on shutdown, and prefetch-thread joining.
Collaborator
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes chat -q/ oneshot exitsHonchoSessionManager.shutdown()instead of only flushingTest plan
python -m pytest tests/hermes_cli/test_tui_resume_flow.py::test_oneshot_shuts_down_memory_provider tests/honcho_plugin/test_async_memory.py::TestAsyncWriterThread::test_shutdown_flushes_session_mode tests/honcho_plugin/test_async_memory.py::TestAsyncWriterThread::test_shutdown_joins_prefetch_threads -q -o 'addopts='python -m pytest tests/hermes_cli/test_tui_resume_flow.py tests/honcho_plugin/test_async_memory.py tests/honcho_plugin/test_session.py -q -o 'addopts='git diff --check