Skip to content

fix: tear down one-shot memory workers#31172

Closed
JohnnyMa9ic wants to merge 2 commits into
NousResearch:mainfrom
JohnnyMa9ic:fix/oneshot-honcho-shutdown
Closed

fix: tear down one-shot memory workers#31172
JohnnyMa9ic wants to merge 2 commits into
NousResearch:mainfrom
JohnnyMa9ic:fix/oneshot-honcho-shutdown

Conversation

@JohnnyMa9ic

@JohnnyMa9ic JohnnyMa9ic commented May 23, 2026

Copy link
Copy Markdown

Summary

  • explicitly shut down one-shot CLI agents, memory providers, and session DBs after hermes -z
  • skip next-turn external memory prefetch for one-shot runs
  • stop Honcho's session-manager async writer during provider shutdown

Test Plan

  • venv/bin/python -m pytest -o addopts='' tests/run_agent/test_memory_sync_interrupted.py tests/cli/test_cli_shutdown_memory_messages.py -q — 21 passed, 1 warning
  • hermes -p bob -z 'Say stable in one word.' — exit 0
  • hermes -p ghost -z 'Say stable in one word.' — exit 0
  • hermes -p warden -z 'Say stable in one word.' — exit 0
  • thread-dump harness exits 0 with only MainThread at atexit

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent loop, run_agent.py, prompt builder comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins tool/memory Memory tool and memory providers area/config Config system, migrations, profiles labels May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/agent Core agent loop, run_agent.py, prompt builder comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P2 Medium — degraded but workaround exists tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants