…udlet#5280)

* Refactor the shortcut adjustments out
- not sure why the action text has no tr() anymore but it still works..!

* Join Functions, If to Switch, Shortcut indirection
- removing "unset" function in lieu of an optional bool parameter in "set"
- reworking if/else cascade into a nice switch for readability
- even more readabily: drop much repeated code & set shortcut once at the end

* Revert shortcut indirection
- This could otherwise drop shortcuts from ALL taskbar items. While this seems fair for now, it could have unintended consequences later. So stay as is for now.

* Also use setShortcuts during toolbar creation

* Define toolbar2 items in order of display

* Mention new shortcuts in tool-tips

* Mention new shortcuts in tool-tips

* Finally set toolbar2 shortcuts

* Add header data

* Add header data

* Undo switch, c++ can't handle strings

* Stupid ;

* Forgot ) as well

* tr() necessary after all

* move comment before function

* inverse logic

* typo

* use inversed logic

This was suggested by the Discord User Kaylee#0064 in the
mudlet-development channel on 2021/06/11T18:56Z.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…et#5245)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.1.5 to 2.2.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.1.5...v2.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Sign dmgs with hardened runtime

* Add codesigning via gon

* Fix indentation

…file (Mudlet#5307)

This is so they can be considered when using the search facilities of the
Qt Creator IDE with the qmake project file.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…5313)

This is done by hiding the connect profile dialogue as quickly as possible
after the load or connect buttons have been clicked (and before the
possibly lengthy profile loading operations commenced). This should close
Mudlet#5303.

Also, it was found that the:
`(void) dlgConnectionProfiles::slot_connectToServer()` slot method was
redundant and could be removed.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

Closes issue Mudlet#5324.

…udlet#5227)

Provide a means to get and set the state of push down buttons (the latter
without executing the associate command or script). It requires adding
members to the `TAction` class to keep track of the `EAction` or
`TFlipButton` instance that is the implementation of the button on a
`TEasyButton` or `TToolBar` respectively. As it happens this showed that
the previous code to regenerate them was creating new buttons each time but
was not deleting the existing ones that were getting replaced.

Also:
* made some members of the `TAtion` class (the name, script and both
commands) private as otherwise there is no point in the setters and getters
also provided!
* simplified the existing `getButtonState()` {that only works within the
script for a button) to remove an unneeded intermediate local (`int`)
value.

Revised to combine ID and name getters and setters for button state

Note that for the getter this is an intermediate stage as is should be
possibble to combine it with the existing `getButtonState()` function that
takes NO arguments but only works within the Lua script for a push-down
button.

Revised to combine new getter functionality into existing getButtonState

This simplifies the UI so that `getButtonState()` works the same as
before but if an button's ID number or "name" is supplied as an argument
the state of the corresponding button (as a boolean though, NOT the
existing and, TBH, odd, integer value 1 or 2, that the original function
produces) is returned. In the event that the matching item is NOT a
push-down button, or that it does not match an existing button then a 'nil'
+ (run-time) error message is returned instead.

Revised to use ID consistently in two functions added/modified in this PR

Refactored to extract code to get TAction instance from {g|s}etButtonState(...)

This was strongly urged upon me by @keneanung & @vadi2 ...!

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

This should close Mudlet#5295 by providing the code that is missing from
`(void) TRoom::readJsonSymbol(...)` - I think it was omitted because the
person who coded the ability to colourise the room symbol text was working
on that whilst I was coding the JSON map handling.

It also fixes:
* a Qt advisory (warning) to use a const reference when using a C++ `for`
loop to iterate through a QJsonArray of custom environements (colors).
* a failure to update the player room indicator when it is changed by
loading a Json Map file.
* a comment in `(void) Host::getPlayerRoomStyleDetails(...)` that is
redundant since we previously removed the mutex for accessors.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

* New translations mudlet-lua.json (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Chinese Traditional)

* New translations mudlet.ts (Finnish)

* New translations mudlet-lua.json (Finnish)

* New translations mudlet.ts (Swedish)

* New translations mudlet-lua.json (Swedish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

* New translations mudlet.ts (Finnish)

Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>

* Add Finnish language to translations

* Update language name

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Mudlet#5286)

Providing an empty table as the second argument (i.e. without sets of
sub-tables as x, y, z coordinates) was causing a fatal crash.

This will close issue Mudlet#5272.

Also:
* fix up some other error messages in the addCustomLine function that
  referred to the wrong argument index - or didn't mention which one was
  involved at all.
* silence some warnings in the same function caused by casting floating
  point numbers to integers or down-casting 64-bit `long long int`s to
  (32-bit) `int`s.
* fix handling for the fifth argument NOT being a three-color component
  (RGB) table - so that it throws a `lua_error(...)` if a table is not
  provided - previously it was ignoring this defect.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>

)

If compression is disabled the existing message:
"Rejecting MCCP v1, because v2 has already been negotiated or FORCE
COMPRESSION OFF is set to ON."
can be a bit confusing when it is MCCP2 that is not being allowed.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

Profile name comes first so it's easier to differentiate between many open profiles

* Implement new commands selectCmdLineText and Geyser.CommandLine:selectText

* Add exception for linter

* Revert the change

Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>

* Add printDebug and printError lua wrappers around debugc, and error to provide more information, including stacktrace, for your debug and error messages.
* Add links to where the documentation will reside, once it is written.
* Add tests for printDebug and printError
* Make errorc internal only for use by printError, and adjust it so its formatting is more in line with the existing errors messages
* allow errorc to be global if and only if the profile is 'Mudlet self-test' in order for tests to be able to spy on it.
* Make tests work with windows or linux path delimiters

…#5395)

* BugFix: try and make connectExitStub(...) work as per the API

This PR should enable connectExitStub(...) to work as close to the existing
published API as possible:
* connectExitStub((integer) fromRoomID, (integer)toRoomID,
                                             (integer or string) direction)
where direction is the initial(s) or full, lower-case, un-hypenated ENGLISH
word for one of the 12 normal exit directions - this will make a two way
exit between the given direction of the fromRoomID room to the toRoomID
room AND the corresponding reverse direction exit from the toRoomID room.
The rooms need not be the same Area but they must BOTH have stub exits in
the required direction.
* `connectExitStub((integer) fromRoomID, (integer) toRoomID)` - this will
make a two way exit between the fromRoomID room to the toRoomID room AND
the corresponding reverse direction exit from the toRoomID room. The rooms
need not be the same Area but the fromRoomID must have only ONE stub exit
with an opposite (reverse) direction one in the toRoomID one - either room
can have other stub exits. Should there be more than one pair of stub exits
a nil + error message will be produced listing the choices for the
direction that can be passed to the three argument function call to make
the exits wanted.
* `connectExitStub((integer) fromRoomID, (integer or string) dirction)`
- this will make a two way exit between the stub exit in the fromRoomID
room to the NEAREST other room IN THE SAME AREA which has a stub exit in
the reverse direction and which lies in the correct relative position
(except for the `in`/`out` directions where this is not relevant). Should
the direction be given as an integer in the range 1 to 12 this will be
rejected (via a nil + error message) because it is ambiguous then whether
the number represents a direction or a toRoomID. Potentially unlike the
prior code, this version properly detects whether a string or number is
supplied as the direction argument.

Also:
* to allow the reporting of the direction as a number and a string in error
messages the `(QString) TRoom::dirCodeToString(const int)` method has been
made `static` so that it can be used in the `TLuaInterpreter` class.
* as indirectly mentioned above
`(int) TLuaInterpreter::dirToNumber(lua_State*, int)` has been revised to
check for a string or integer argument being examined - the prior code
may not work as anticipated because it used `lua_isxxxx(...)` functions
which can coerce the value they are dealing with (a number can be coerced
into a string) - which messes with the logic.
* in places in the revised methods the integer constant values have been
replaced with the `DIR_XXXXX` values defined in the `TRoom` class header
file.
* to simplify (!) the coding the three different forms of the Lua API are
implemented in three separate `(QString) TMap::connectExitStubByXxxx(...)
methods which collectively replace the original
`(void) TMap::connectExitStub(...)` one. They are responsible for
generating most of the Lua API error messages for this function and they
indicate success by returning an empty string.

This should close Mudlet#2386.

Revise: add a suggestion to the user on how to proceed on a message

Signed-off by: Stephen Lyons <slysven@virginmedia.com>
Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>

* Only enable IRE driver GA bugfix for IRE games

* Review feedback

* Unregister fonts upon package/module uninstall

* Add missing newline

…er ldoc comments (Mudlet#5471)

* initial secure IRC

* Update TLuaInterpreter.cpp

* Update TLuaInterpreter.cpp

* applied suuggestions

* missed one

this part made it where if you changed settings while connected then it would not properly connect again

* add tooltip mentioning port number suggestion

Communi desktop client automatically checks the box if you type in 6697, 7000, or 7070.
https://github.com/communi/communi-desktop/blob/master/src/app/connectpage.cpp#L45

RFC 7194 just mentions 6697

Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>

Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>

Remove trimmed() from one spot in the tab completion code.  Look closer at it later and see if there is a reason it was there.  Trimmed does front and back, but back comes from the autocomplete dictionary thing so I -think- this is only consequence, unless the suggestion thing includes spaces at the end or something odd like that.  Issue 579.

* use painter event instead of proxy for tab style change

* codefactor

* override painterEvent

* get rid of TStyle class as it is not needed anymore

* try to please clang tidy

* suggestions

…iable (Mudlet#5464)

It turns out that the variable concerned, `__Pick` is a very badly named
(as symbols containing a double underscore or an underscore and followed by
an upper-case letter are explicitly reserved, e.g. see:
https://stackoverflow.com/a/1449301/4805858 )

Fortunately, it isn't needed and there is no need to pass the class member
it is a copy of via the `drawRoom(...)` method in the `T2DMap` class as
that can use the class value directly quite safely - as it never modifies
it.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

This removes the need for the code that uses the `dlgRoomExits` class from
having to also call that class's `init()` method - the room ID for which
the dialogue is being used is now to be provided in the constructor rather
than in the now made private method.

As a side-effect it become obvious that there is no need to provide the
room ID as an argument to the `dlgRoomExit::initExit(...)` method as the
value is already available in the class's member `(int) mRoomID`!

This PR is a part that has been extracted from the draft (and to be
replaced) PR Mudlet#5308 - that is to be broken up into smaller, easier to
digest, chunks! 8-)

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

)

These have no place in C++ code!

Unfortunately there are some in third party bits which can't be fixed here
but should be raised upstream.

This should help with Mudlet#1650.

During review it became necessary to remove some changes that
clang-tidy choked on, hence the revision to the title to say:
"(some of)"! There may be a better way - but it doesn't jump out at
me - to deal with the outstanding ones.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…udlet#5501)

As the header file that contains the structure:
`inline static const OrderedMap<QString, GameDetails> scmDefaultGames`
is used by so many other classes it causes nearly one hundred compile
time warnings (50 each) of these:
`missing initializer for member 'mudlet::GameDetails::websiteInfo'
  [-Wmissing-field-initializers]`
`missing initializer for member 'mudlet::GameDetails::icon'
  [-Wmissing-field-initializers]`

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…short + add position as option for setTitle (Mudlet#5493)

* get rid of shrink_title and add position to title

* Update GeyserAdjustableContainer.lua

* change position to format

* resetTitle should really reset the title now

* Add workflow to run Danger checks
* Add danger checks in JS
* Update CONTRIBUTING with new PR standards being enforced via Danger in this PR
* Update workflows which open PRs to have their titles conform to the new PR title rules

* Improve PTB changelog generation
* Make the headings actually headings, and remove the extra breaks. Remove commented out code.
* Make it look more like our last release post changelogs

…ipt. (Mudlet#5508)

* Remove emoji from the ptb changelog, as it turns out they are not rendered properly
* Adjust changelog not to include categories with no changes in them

…xits (Mudlet#5505)

This will make changing/adding the columns easier as part of what was
created as the draft (and to be replaced) PR Mudlet#5308 - that is to be broken
up into smaller, easier to digest, chunks! 8-)

There is a single set of constants which are defined in the `exitstreewidget`
class but used also by the `dlgRoomExit` one by virtue of making it a friend
of the former.

As it happens I spotted the need for both classes to have these constants
when I reviewed `(void) ExitsTreeWidget::keyPressEvent(QKeyEvent*)`
and spotted that I had not revised it to close the correct persistent editors
in the merge commit 83db9f9 (part of PR Mudlet#439) seven years ago!

This will make changing/adding the columns easier as part of what was

Revised slightly (converted an empty switch "default:" case from a `;`
to a `{}`) to placate the CodeFactor god/daemon...!

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…udlet#5509)

### This is for LINUX only!

This pulls in changes for Unicode 13.1. It also will remove older versions
of the font that prior versions of Mudlet will place in its own bit of the
file-system so that the FontManager class will not try to load more than
one instance of a font with an identical "family name" (which it will not
IIRC).

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>