Only enable IRE driver GA bugfix for IRE games#5474
Merged
vadi2 merged 2 commits intodevelopmentfrom Oct 3, 2021
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I tested this fix: created a new profile connecting to TFE, confirmed the option was unchecked and output looks good. Created new profile and connected to Aetolia, confirmed option is checked and output looks good there too. |
SlySven
approved these changes
Oct 2, 2021
src/dlgConnectionProfiles.cpp
Outdated
| dir.setSorting(QDir::Time); | ||
| QStringList entries = dir.entryList(QDir::Files, QDir::Time); | ||
| bool preInstallPackages = false; | ||
| bool loadingForFirstTime = false; |
Member
There was a problem hiding this comment.
🤔 It is a little unclear, but this actually means "loadingThisProfileForFirstTime" - given that that is a little long, can we add a comment to that effect here instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Only enable IRE driver GA bugfix for IRE games
Motivation for adding to Mudlet
Other non-IRE games were affected adversely, see #5440
Other info (issues closed, discussion etc)
Fix #5440