Fix: eliminate a load of warnings about missing-field-initializers#5501
Conversation
As the header file that contains the structure: `inline static const OrderedMap<QString, GameDetails> scmDefaultGames` is used by so many other classes it causes nearly one hundred compile time warnings (50 each) of these: `missing initializer for member 'mudlet::GameDetails::websiteInfo' [-Wmissing-field-initializers]` `missing initializer for member 'mudlet::GameDetails::icon' [-Wmissing-field-initializers]` Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
This issue was really spamming me: 😲 |
|
clang-tidy review says "All clean, LGTM! 👍" |
vadi2
left a comment
There was a problem hiding this comment.
That is strange... where are you getting this check from? It's not documented on https://clang.llvm.org/extra/clang-tidy/checks/list.html, nor do I have it locally, nor does our CI clang-tidy know about it
I am not sure - the only thing I can find that might to fit is this clang-tidy one: Which seems to link to: https://clang-analyzer.llvm.org/available_checks.html#optin_checkers |
As the header file that contains the structure:
inline static const OrderedMap<QString, GameDetails> scmDefaultGamesis used by so many other classes it causes nearly one hundred compile time warnings (50 each) of these:missing initializer for member 'mudlet::GameDetails::websiteInfo' [-Wmissing-field-initializers]missing initializer for member 'mudlet::GameDetails::icon' [-Wmissing-field-initializers]Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Not sure that this is something we need to mention?