BugFix: prevent crashing from double-click on connect button#5313
Conversation
This is done by hiding the connect profile dialogue as quickly as possible after the load or connect buttons have been clicked (and before the possibly lengthy profile loading operations commenced). This should close Mudlet#5303. Also, it was found that the: `(void) dlgConnectionProfiles::slot_connectToServer()` slot method was redundant and could be removed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This seems right. Even on a slower computer, with this build I can not crash it even by highlighting the button and pressing both enter keys at once. |
keneanung
left a comment
There was a problem hiding this comment.
Looks good to me. One question: does the button appear if you reopen the dialog?
How about the "offline" button?
I read the same, but actually no buttons are hidden at all, instead the whole popup window is. |
|
Right... Thanks @Kebap |
They are both treated in the same way - so if it is okay for one it should be okay for the other as well. |
This is done by hiding the connect profile dialogue as quickly as possible after the load or connect buttons have been clicked (and before the possibly lengthy profile loading operations commenced). This should close #5303.
Also, it was found that the:
(void) dlgConnectionProfiles::slot_connectToServer()slot method was redundant and could be removed.Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Reduce possibility of crashing Mudlet by double-clicking on "load" or "connect" buttons in profile selection dialogue.