Add Legends of the Jedi connection option#5306
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Jul 6, 2021
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
| mudServer = QStringLiteral("Legends of the Jedi"); | ||
| if (!deletedDefaultMuds.contains(mudServer)) { | ||
| pItem = new QListWidgetItem(); | ||
| setupMudProfile(pItem, mudServer, getDescription(QStringLiteral("legendsofthejedi.com"), 0, mudServer), QStringLiteral(":/icons/legendsofthejedi_120x30.png")); |
Contributor
There was a problem hiding this comment.
warning: Potential leak of memory pointed to by pItem [clang-analyzer-cplusplus.NewDeleteLeaks]
setupMudProfile(pItem, mudServer, getDescription(QStringLiteral("legendsofthejedi.com"), 0, mudServer), QStringLiteral(":/icons/legendsofthejedi_120x30.png"));
^
../../Qt/5.14.1/gcc_64/include/QtCore/qstringliteral.h:66:6: note: expanded from macro 'QStringLiteral'
([]() noexcept -> QString { \
^
src/dlgConnectionProfiles.cpp:1705:9: note: Assuming 'success' is true
if (!success) {
^
src/dlgConnectionProfiles.cpp:1705:5: note: Taking false branch
if (!success) {
^
src/dlgConnectionProfiles.cpp:1710:5: note: Calling 'dlgConnectionProfiles::fillout_form'
fillout_form();
^
src/dlgConnectionProfiles.cpp:1325:9: note: Assuming the condition is false
if (mProfileList.isEmpty()) {
^
src/dlgConnectionProfiles.cpp:1325:5: note: Taking false branch
if (mProfileList.isEmpty()) {
^
src/dlgConnectionProfiles.cpp:1355:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1355:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1361:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1361:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1367:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1367:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1373:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1373:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1379:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1379:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1385:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1385:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1391:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1391:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1397:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1397:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1403:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1403:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1409:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1409:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1415:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1415:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1421:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1421:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1427:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1427:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1433:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1433:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1439:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1439:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1445:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1445:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1451:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1451:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1457:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1457:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1463:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1463:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1469:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1469:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1476:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1476:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1482:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1482:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1488:9: note: Assuming the condition is false
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1488:5: note: Taking false branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1494:9: note: Assuming the condition is true
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1494:5: note: Taking true branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1495:17: note: Memory is allocated
pItem = new QListWidgetItem();
^
src/dlgConnectionProfiles.cpp:1500:9: note: Assuming the condition is true
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1500:5: note: Taking true branch
if (!deletedDefaultMuds.contains(mudServer)) {
^
src/dlgConnectionProfiles.cpp:1502:58: note: Potential leak of memory pointed to by 'pItem'
setupMudProfile(pItem, mudServer, getDescription(QStringLiteral("legendsofthejedi.com"), 0, mudServer), QStringLiteral(":/icons/legendsofthejedi_120x30.png"));
^
../../Qt/5.14.1/gcc_64/include/QtCore/qstringliteral.h:66:6: note: expanded from macro 'QStringLiteral'
([]() noexcept -> QString { \
^
Member
There was a problem hiding this comment.
This one seems to be a potential issue in existing code, nothing you added
Member
|
The setup is pretty nice, congratulations 😄 I've got one complaint, but this is on us: Currently, the generic mapper is installed by default into the LOTJ profiles, which overlaps with the mapper in the UI. We should fix that before adding this. Mudlet/src/dlgConnectionProfiles.cpp Line 2024 in bc76704 |
Contributor
Author
|
Aha, I wondered about that. Would it make sense to just have our UI package call uninstallPackage on it since it's providing its own? |
Member
|
That might be a possible workaround, though messing with other installed packages on a profile irks me. I'd be happier if we found a solution for the actual problem. Thoughts @vadi2? |
Member
|
Uninstalling the generic mapper is how it's done right now. Happy to rework the default packages code to support excluding the generic mapper. |
Contributor
Author
|
For now, based on the docs referencing that practice for the generic mapper specifically, I just added that to our package. |
Member
|
That's works well, but for future reference examples in specs are not normative! |
vadi2
approved these changes
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Adds default connection info for Legends of the Jedi.
Motivation for adding to Mudlet
Add to the list of games offering a good experience in Mudlet and make it easier for players to find LotJ.