Unregister fonts upon package/module uninstall#5480
Merged
vadi2 merged 2 commits intodevelopmentfrom Oct 4, 2021
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
demonnic
approved these changes
Oct 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Unregister fonts upon package/module uninstall.
Motivation for adding to Mudlet
So packages/modules containing custom fonts can be reinstalled w/o having to restart Mudlet on Windows.
Other info (issues closed, discussion etc)
Fix #5479.
I suspect the issue is that Qt is hanging onto a file handle to the font file - so let's try calling the complementary QFontDatabase::removeApplicationFont function.
@demonnic can you test if this fixes it on Windows?