Fix setBorderSizes() when called with 4 arguments#5325
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Jul 19, 2021
Merged
Fix setBorderSizes() when called with 4 arguments#5325SlySven merged 1 commit intoMudlet:developmentfrom
SlySven merged 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
approved these changes
Jul 19, 2021
Member
SlySven
left a comment
There was a problem hiding this comment.
Hey, that is exactly the change my PR would have done - if I could have uploaded it from my current location (my air-conditioned local authority's library building)!
<aside>I can't get ssh to work on this location in Windoze...! 🙄 </aside>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
demonnic
approved these changes
Jul 19, 2021
Contributor
Member
No-one - which, given my record, is just as well! 😜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fix setBorderSizes() when called with 4 arguments
Motivation for adding to Mudlet
Bugfix
Other info (issues closed, discussion etc)
Fix #5324
Release post highlight