Improve: simplify dlgRoomExits() invocation#5498
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Oct 9, 2021
Merged
Conversation
This removes the need for the code that uses the `dlgRoomExits` class from having to also call that class's `init()` method - the room ID for which the dialogue is being used is now to be provided in the constructor rather than in the now made private method. As a side-effect it become obvious that there is no need to provide the room ID as an argument to the `dlgRoomExit::initExit(...)` method as the value is already available in the class's member `(int) mRoomID`! This PR is a part that has been extracted from the draft (and to be replaced) PR Mudlet#5308 - that is to be broken up into smaller, easier to digest, chunks! 8-) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
commented
Oct 9, 2021
| const QString doubleParagraph{QStringLiteral("<p>%1</p><p>%2</p>")}; | ||
|
|
||
| dlgRoomExits::dlgRoomExits(Host* pH, QWidget* pW) : QDialog(pW), mpHost(pH), mpEditItem(nullptr), pR(), mRoomID(), mEditColumn() | ||
| dlgRoomExits::dlgRoomExits(Host* pH, const int roomNumber, QWidget* pW) |
Member
Author
There was a problem hiding this comment.
<aside>I don't know about anyone else but I find the "one member per line" layout (that we used to use) easier to read than the all on one line that our current .clang-format currently produces...</aside>
Member
There was a problem hiding this comment.
Yeah, AFAIK it's a tool limitation.
SlySven
commented
Oct 9, 2021
| void slot_checkModified(); | ||
|
|
||
| private: | ||
| void init(); |
Member
Author
There was a problem hiding this comment.
Reordered to put the private methods before the members for consistency...
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
6 tasks
vadi2
approved these changes
Oct 9, 2021
| const QString doubleParagraph{QStringLiteral("<p>%1</p><p>%2</p>")}; | ||
|
|
||
| dlgRoomExits::dlgRoomExits(Host* pH, QWidget* pW) : QDialog(pW), mpHost(pH), mpEditItem(nullptr), pR(), mRoomID(), mEditColumn() | ||
| dlgRoomExits::dlgRoomExits(Host* pH, const int roomNumber, QWidget* pW) |
Member
There was a problem hiding this comment.
Yeah, AFAIK it's a tool limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for the code that uses the
dlgRoomExitsclass from having to also call that class'sinit()method - the room ID for which the dialogue is being used is now to be provided in the constructor rather than in the now made private method.As a side-effect it become obvious that there is no need to provide the room ID as an argument to the
dlgRoomExit::initExit(...)method as the value is already available in the class's member(int) mRoomID!This PR is a part that has been extracted from the draft (and to be replaced) PR #5308 - that is to be broken up into smaller, easier to digest, chunks! 8-)
Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
None - not something that needs to be announced!