Skip to content

Infrastructure: remove unrendered emoji characters from changelog script.#5508

Merged
demonnic merged 2 commits intoMudlet:developmentfrom
demonnic:no_emoji_in_ptb_changelog
Oct 12, 2021
Merged

Infrastructure: remove unrendered emoji characters from changelog script.#5508
demonnic merged 2 commits intoMudlet:developmentfrom
demonnic:no_emoji_in_ptb_changelog

Conversation

@demonnic
Copy link
Copy Markdown
Member

@demonnic demonnic commented Oct 12, 2021

Brief overview of PR changes/additions

First PTB came out, and the emoji in the changelogs were not rendered properly, as shown in the below picture. This removes them so future changelogs look better.

image

Motivation for adding to Mudlet

Want it to look nice.

Other info (issues closed, discussion etc)

Release post highlight

@demonnic demonnic requested a review from a team October 12, 2021 14:09
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Oct 12, 2021 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 12, 2021 •
edited
Loading

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against ae84f30

@demonnic demonnic changed the title Fix: remove unrendered emoji characters from changelog script. Infrastructure: remove unrendered emoji characters from changelog script. Oct 12, 2021
vadi2
vadi2 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I see there's also "added: none", "improved: "none" - we can remove that bit as well

@demonnic
Copy link
Copy Markdown
Member Author

demonnic commented Oct 12, 2021

image

Fixed:

Fix: don't show jibberish when Adjustable Container title bar is too short + add position as option for setTitle (#5493)

Fix: eliminate a load of warnings about missing-field-initializers (#5501)

Infrastructure:

Infrastructure: Improve ptb changelog generation (#5500)

Infrastructure: danger checks in JS (#5489)

Infrastructure: add knowledge for debug symbols in builds (#4774)

Other:

Remove emoji from the ptd changelog, as it turns out they are not rendered properly

@demonnic demonnic merged commit afbbf60 into Mudlet:development Oct 12, 2021
@demonnic demonnic deleted the no_emoji_in_ptb_changelog branch October 12, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadi2 vadi2 vadi2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@demonnic @vadi2