BugFix: fix Json Map room symbol loading#5312
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Jul 20, 2021
Merged
Conversation
This should close Mudlet#5295 by providing the code that is missing from `(void) TRoom::readJsonSymbol(...)` - I think it was omitted because the person who coded the ability to colourise the room symbol text was working on that whilst I was coding the JSON map handling. It also fixes: * a Qt advisory (warning) to use a const reference when using a C++ `for` loop to iterate through a QJsonArray of custom environements (colors). * a failure to update the player room indicator when it is changed by loading a Json Map file. * a comment in `(void) Host::getPlayerRoomStyleDetails(...)` that is redundant since we remove the mutex for accessors. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Kebap
approved these changes
Jul 13, 2021
Contributor
Kebap
left a comment
There was a problem hiding this comment.
Fixes the bug as expected, also with emoji as symbols!
Did not test the scope creep as I didn't even understand.
vadi2
approved these changes
Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #5295 by providing the code that is missing from
(void) TRoom::readJsonSymbol(...)- I think it was omitted because the person who coded the ability to colourise the room symbol text was working on that whilst I was coding the JSON map handling.It also fixes:
forloop to iterate through a QJsonArray of custom environements (colors).(void) Host::getPlayerRoomStyleDetails(...)that is redundant since we remove the mutex for accessors.Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Room symbols (and their colouration if they are not colour emojis) will now be loaded from a JSON format map file.