Add option for secure IRC connections#5473
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
clang-tidy review says "All clean, LGTM! 👍" |
this part made it where if you changed settings while connected then it would not properly connect again
|
|
||
| QPair<bool, QString> dlgIRC::writeIrcHostSecure(Host* pH, bool secure) | ||
| { | ||
| return pH->writeProfileData(dlgIRC::HostSecureCfgItem, (secure ? QLatin1String("true") : QLatin1String("false"))); |
There was a problem hiding this comment.
This works great as of now. But when it saves false to file, it apparently throws a newline in front. Still functional but confusing to me. Maybe writeProfileData does something I'm not expecting.
$ cat irc_secure
true
Alpha@Alpha-F5BZ322 MSYS /c/Users/Alpha/.config/mudlet/profiles/zzz-three
$ cat irc_secure
false
|
Should I switch the default connection from Otherwise SlySven caught everything that I was planning to come back to and more, very much appreciated. I'll switch it out of draft mode. |
vadi2
left a comment
There was a problem hiding this comment.
Works! Though I was confused at first because I just ticked the option, didn't realise I have to change the port as well, and the connection wasn't working. Similar problem that the connection dialog would be having...
Agree on changing the default to be more secure for new profiles only. We don't want to break existing profiles by changing them to the secure option without having updated the port...
src/ui/profile_preferences.ui
Outdated
| <item row="2" column="0" colspan="2"> | ||
| <widget class="QCheckBox" name="ircHostSecure"> | ||
| <property name="text"> | ||
| <string>TLS/SSL secure connection</string> |
There was a problem hiding this comment.
| <string>TLS/SSL secure connection</string> | |
| <string>Use a secure connection</string> |
- tooltip saying it'll use TLS/SSL for the technically-minded folk who'd like more details
Communi desktop client automatically checks the box if you type in 6697, 7000, or 7070. https://github.com/communi/communi-desktop/blob/master/src/app/connectpage.cpp#L45 RFC 7194 just mentions 6697
Brief overview of PR changes/additions
Now it can connect to IRC servers using Transport Layer Security.
setIrcServerincludes optional boolean argument.getIrcServerreturns an extra boolean. New checkbox on preferences.Motivation for adding to Mudlet
Allows secure connection to IRC servers.
Other info (issues closed, discussion etc)
Closes #5345
Release post highlight
IRC client can connect to secure servers