do not trim whitespace for tab completion#5477
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Oct 8, 2021
Merged
Conversation
Remove trimmed() from one spot in the tab completion code. Look closer at it later and see if there is a reason it was there. Trimmed does front and back, but back comes from the autocomplete dictionary thing so I -think- this is only consequence, unless the suggestion thing includes spaces at the end or something odd like that. Issue 579.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vadi2
approved these changes
Oct 8, 2021
Member
vadi2
left a comment
There was a problem hiding this comment.
Looks good, though I suspect it might have some side effects. Let's test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Tab key to autocomplete was removing leading spaces. Some people use a leading space to bypass aliases and would prefer to preserve it when using autocomplete.
Remove trimmed() from one spot in the tab completion. The list of proposed words I think will not have spaces at the end, so trimming the result only really touches the front.
Motivation for adding to Mudlet
Trimming front is not a necessary or expected part of autocompletion.
Other info (issues closed, discussion etc)
Closes #579
Release post highlight
Leading whitespace no longer stripped by tab autocomplete.