Add a descriptive title to the editor#5342
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Aug 2, 2021
Merged
Conversation
Profile name comes first so it's easier to differentiate between many open profiles
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
Linked issue actually suggested to indicate whether you're in scripts, variables, triggers, etc. Did you drop that for a reason or leave for later? Maybe @halimcme can better judge if this will already suffice to satisfy the original request. |
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile name comes first so it's easier to differentiate between many open profiles
Brief overview of PR changes/additions
Add a descriptive title to the editor
Profile name comes first so it's easier to differentiate between many open profiles
Motivation for adding to Mudlet
See #5341
Other info (issues closed, discussion etc)
Close #5341
Release post highlight